Skip to content

Commit 9bceb78

Browse files
Merge pull request #212 from Sandipkakadiya/review
Review & Release
2 parents 47e2a3b + 8ae4ee5 commit 9bceb78

File tree

6 files changed

+12
-9
lines changed

6 files changed

+12
-9
lines changed

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,4 @@ before_script:
2626
script:
2727
- ./../flutter/bin/flutter analyze .
2828
- ./../flutter/bin/cache/dart-sdk/bin/dartfmt --dry-run lib
29+
- ./../flutter/bin/flutter test

CHANGELOG.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Changelog
22

33

4-
## 1.2.3 - 2020-11-12
4+
## 1.2.4 - 2020-11-12
55

66
### Fixed
77
* [GFProgressBar] issue.
@@ -11,6 +11,11 @@
1111
* [GFCarousel] issue. #185
1212
* Many more minor improvements.
1313

14+
### Added
15+
* Test cases added for couple of components
16+
- GFLoader
17+
- GFTypography
18+
1419

1520

1621
## 1.2.2 - 2020-10-02

example/pubspec.lock

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ packages:
9292
path: ".."
9393
relative: true
9494
source: path
95-
version: "1.2.3"
95+
version: "1.2.4"
9696
matcher:
9797
dependency: transitive
9898
description:

lib/components/appbar/gf_appbar.dart

+3-1
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,9 @@ class _GFAppBarState extends State<GFAppBar> {
309309
assert(debugCheckHasMaterialLocalizations(context));
310310
final ThemeData theme = Theme.of(context);
311311
final AppBarTheme appBarTheme = AppBarTheme.of(context);
312-
final ScaffoldState scaffold = Scaffold.of(context, nullOk: true);
312+
final ScaffoldState scaffold = Scaffold.of(context);
313+
// final ScaffoldState scaffold =Scaffold.of(context, nullOk: true);
314+
// final ScaffoldState scaffold = Scaffold.maybeOf(context);
313315
final ModalRoute<dynamic> parentRoute = ModalRoute.of(context);
314316
final bool hasDrawer = scaffold?.hasDrawer ?? false;
315317
final bool hasEndDrawer = scaffold?.hasEndDrawer ?? false;

pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: getwidget
22
description: GetWidget is open source libraries that come with pre-build 1000+ UI components. It makes development faster & more enjoyable. You can customize the component as per your need.
3-
version: 1.2.3
3+
version: 1.2.4
44
homepage: https://github.com./ionicfirebaseapp/getwidget
55

66
environment:

test/getflutter_test.dart

-5
This file was deleted.

0 commit comments

Comments
 (0)