Skip to content

Commit 64d1a73

Browse files
committed
[Tests] split out and enhance "no-proto" tests
1 parent 11540a5 commit 64d1a73

File tree

2 files changed

+30
-25
lines changed

2 files changed

+30
-25
lines changed

.github/workflows/node-noproto.yml

+29
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
name: 'Tests: node --disable-proto=throw'
2+
3+
on: [pull_request, push]
4+
5+
jobs:
6+
throw:
7+
uses: ljharb/actions/.github/workflows/node.yml@main
8+
with:
9+
range: '>= 12.17'
10+
type: minors
11+
skip-ls-check: true
12+
after_install: "npm link && npm link dunder-proto"
13+
command: "NODE_OPTIONS='--disable-proto=throw' npx tape 'tests/**/*.js'"
14+
15+
delete:
16+
uses: ljharb/actions/.github/workflows/node.yml@main
17+
with:
18+
range: '>= 12.17'
19+
type: minors
20+
skip-ls-check: true
21+
after_install: "npm link && npm link dunder-proto"
22+
command: "NODE_OPTIONS='--disable-proto=delete' npx tape 'tests/**/*.js'"
23+
24+
node:
25+
name: 'node --disable-proto'
26+
needs: [throw, delete]
27+
runs-on: ubuntu-latest
28+
steps:
29+
- run: true

.github/workflows/node-twenties.yml

+1-25
Original file line numberDiff line numberDiff line change
@@ -13,33 +13,9 @@ jobs:
1313
type: minors
1414
command: npm run tests-only
1515

16-
no-proto:
17-
name: 'node, --disable-proto=delete'
18-
runs-on: ubuntu-latest
19-
steps:
20-
- name: Harden Runner
21-
uses: step-security/harden-runner@v2
22-
with:
23-
disable-sudo: true
24-
egress-policy: audit
25-
allowed-endpoints: >
26-
github.com.:443
27-
raw.githubusercontent.com:443
28-
nodejs.org:443
29-
iojs.org:443
30-
registry.npmjs.org:443
31-
actions-results-receiver-production.githubapp.com:443
32-
33-
- uses: actions/checkout@v4
34-
with:
35-
show-progress: false
36-
- uses: ljharb/actions/node/install@main
37-
- run: NODE_OPTIONS=--disable-proto=delete npm run tests-only
38-
- uses: codecov/[email protected]
39-
4016
finisher:
41-
needs: [tests, no-proto]
4217
name: 'node >= 20'
18+
needs: [tests]
4319
runs-on: ubuntu-latest
4420
steps:
4521
- run: true

0 commit comments

Comments
 (0)