-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Don't break when docProps/core.xml contains <cp:contentType /> #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/xlsx/xform/core/core-xform.js
Outdated
@@ -27,6 +27,7 @@ var CoreXform = module.exports = function() { | |||
'cp:revision': new DateXform({tag: 'cp:revision'}), | |||
'cp:version': new StringXform({tag: 'cp:version'}), | |||
'cp:contentStatus': new StringXform({tag: 'cp:contentStatus'}), | |||
'cp:contentType': new DateXform({tag: 'cp:contentType'}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think this should be a StringXform
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right, nice catch. I had that originally, but started playing around because that enfant terrible spreadsheet still didn't parse :)
Fixed.
1eaede2
to
3b46510
Compare
I just learned that the Excel file in question is an export from Xero, which is a piece of accounting software. |
<cp:coreProperties ...><cp:contentType /></cp:coreProperties>
3b46510
to
75e5f21
Compare
I guess the |
I also see documents with There is example of a such file |
@salterok, thanks for weighing in! I've added a regression test based on the file that you linked to. |
I've encountered a spreadsheet that contains:
which causes exceljs to break with:
Unfortunately I'm not able to share the spreadsheet that this happened with, and I don't know how it was created. If it's important I can try to create a synthetic test case with this construct in it.