Skip to content

Commit 9de989b

Browse files
committed
okhttp: Avoid DNS lookup in test
Our tests assume localhost is in /etc/hosts or uses some other form of local-only resolution. But that wouldn't apply to "host". What was happening is this was causing a DNS resolution, which would fail, and the InetSocketAddress would be "unresolved". Thus, the equivalent and faster code would be `InetSocketAddress.createUnresolved("host", 1234)`. But there doesn't seem to be any reason to avoid localhost in this test, so swap to the more typical solution instead. This should avoid flakes like: ``` io.grpc.okhttp.OkHttpClientTransportTest > invalidAuthorityPropagates FAILED org.junit.runners.model.TestTimedOutException: test timed out after 10 seconds at [email protected]/java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method) at [email protected]/java.net.InetAddress$PlatformNameService.lookupAllHostAddr(InetAddress.java:929) at [email protected]/java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1529) at [email protected]/java.net.InetAddress$NameServiceAddresses.get(InetAddress.java:848) at [email protected]/java.net.InetAddress.getAllByName0(InetAddress.java:1519) at [email protected]/java.net.InetAddress.getAllByName(InetAddress.java:1378) at [email protected]/java.net.InetAddress.getAllByName(InetAddress.java:1306) at [email protected]/java.net.InetAddress.getByName(InetAddress.java:1256) at [email protected]/java.net.InetSocketAddress.<init>(InetSocketAddress.java:220) at app//io.grpc.okhttp.OkHttpClientTransportTest.invalidAuthorityPropagates(OkHttpClientTransportTest.java:1687) ```
1 parent f1f40b0 commit 9de989b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1685,7 +1685,7 @@ public void shutdownDuringConnecting() throws Exception {
16851685
public void invalidAuthorityPropagates() {
16861686
clientTransport = new OkHttpClientTransport(
16871687
channelBuilder.buildTransportFactory(),
1688-
new InetSocketAddress("host", 1234),
1688+
new InetSocketAddress("localhost", 1234),
16891689
"invalid_authority",
16901690
"userAgent",
16911691
EAG_ATTRS,

0 commit comments

Comments
 (0)