Skip to content

Fix for Node v22.8.0 #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weagle08 opened this issue Sep 7, 2024 · 1 comment
Open

Fix for Node v22.8.0 #836

weagle08 opened this issue Sep 7, 2024 · 1 comment

Comments

@weagle08
Copy link

weagle08 commented Sep 7, 2024

What is wrong?

I'm attempting to update packages to the latest as install failes for newer versions of Node (v22.8.0). However when I update all dependencies and run yarn make I get the build failure in the image. I'm not familiar enough with the build process to know what the error means. If someone could point me in the right direction I can get a PR in after all tests pass.

Where does it happen?

The gl library needs to be updated to latest. I've attempted to do the full chain with gpu-mock.js and this so I can update brain.js, but fail with the attached error.

How do we replicate the issue?

Update all dependencies and dev dependencies to latest. Then run yarn make while on Node v22.8.0 on Linux.
I have an updated fork here:
gpu.js fork

How important is this (1-5)?

5, it completely breaks useage of this library on newer versions of Node.

Expected behavior (i.e. solution)

npm install, npm run build, npm run test all succeed.

image

@JenLyndle
Copy link
Contributor

JenLyndle commented Feb 13, 2025

Thanks weagle08 for pointing me in the right direction. I was able to update the dependencies as per your fork. The build works with Node v22.14.0. It does not work on 22 due to a bug in vinyl js which gulp depends on - gulpjs/vinyl-fs#350. Node 23 doesn't work due to stackgl/headless-gl#303. Also, the gulp build addon for streamx needed to be changed as per gulpjs/gulp#2802. The PR is #840. I am using gpu.js in browser and was able to verify that our use case seemed to work as expected with the built dist files. The tests passed fine but am not sure what other functionalities are affected by this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants