Skip to content

Integrate Property with the GodotConvert API #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lilizoey opened this issue Oct 14, 2023 · 0 comments · Fixed by #595
Closed

Integrate Property with the GodotConvert API #453

lilizoey opened this issue Oct 14, 2023 · 0 comments · Fixed by #595
Labels
c: register Register classes, functions and other symbols to GDScript feature Adds functionality to the library

Comments

@lilizoey
Copy link
Member

lilizoey commented Oct 14, 2023 •
edited
Loading

In #421 we didn't integrate Property with the new API. This was to limit scope, however it means we now have a bunch of repeated effort since both Property and ToGodot/FromGodot both do conversions in different ways.

Property should instead be changed to using ToGodot and FromGodot as their conversion methods.

There is a derive macro for Property and that macro should likely be merged with the ToGodot and FromGodot derive macros, see #452.
@lilizoey lilizoey added feature Adds functionality to the library c: register Register classes, functions and other symbols to GDScript labels Oct 14, 2023
@lilizoey lilizoey mentioned this issue Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: register Register classes, functions and other symbols to GDScript feature Adds functionality to the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Var use GodotConvert::Via to align it with ToGodot and FromGodot lilizoey/gdextension
1 participant
@lilizoey