fix

Author: wxiaoguang

modules/markup/html.go

@@ -329,6 +329,15 @@ func visitNode(ctx *RenderContext, procs []processor, node *html.Node) *html.Nod
 		return visitNodeImg(ctx, node)
 	} else if node.Data == "video" {
 		return visitNodeVideo(ctx, node)
+	} else if node.Data == "script" || node.Data == "style" {
+		// to match GitHub's behavior: some tags are rendered as text content
+		// and for unclosed tags, render the text content as much as possible
+		sb := &strings.Builder{}
+		_ = html.Render(sb, node)
+		newNode := &html.Node{Type: html.RawNode, Data: html.EscapeString(sb.String())}
+		node.Parent.InsertBefore(newNode, node)
+		node.Parent.RemoveChild(node)
+		return newNode.NextSibling
 	}
 
 	if node.Data == "a" {

modules/markup/html_test.go

@@ -469,7 +469,7 @@ func Test_ParseClusterFuzz(t *testing.T) {
 	assert.NotContains(t, res.String(), "<html")
 }
 
-func TestPostProcess_RenderDocument(t *testing.T) {
+func TestPostProcess(t *testing.T) {
 	setting.StaticURLPrefix = markup.TestAppURL // can't run standalone
 	defer testModule.MockVariableValue(&markup.RenderBehaviorForTesting.DisableAdditionalAttributes, true)()
 
@@ -480,7 +480,7 @@ func TestPostProcess_RenderDocument(t *testing.T) {
 		assert.Equal(t, strings.TrimSpace(expected), strings.TrimSpace(res.String()))
 	}
 
-	// Issue index shouldn't be post processing in a document.
+	// Issue index shouldn't be post-processing in a document.
 	test(
 		"#1",
 		"#1")
@@ -490,7 +490,7 @@ func TestPostProcess_RenderDocument(t *testing.T) {
 		"go-gitea/gitea#12345",
 		`<a href="/go-gitea/gitea/issues/12345" class="ref-issue">go-gitea/gitea#12345</a>`)
 
-	// Test that other post processing still works.
+	// Test that other post-processing still works.
 	test(
 		":gitea:",
 		`<span class="emoji" aria-label="gitea"><img alt=":gitea:" src="`+setting.StaticURLPrefix+`/assets/img/emoji/gitea.png"/></span>`)
@@ -499,6 +499,11 @@ func TestPostProcess_RenderDocument(t *testing.T) {
 		`Some text with <span class="emoji" aria-label="grinning face with smiling eyes">😄</span> in the middle`)
 	test("http://localhost:3000/person/repo/issues/4#issuecomment-1234",
 		`<a href="http://localhost:3000/person/repo/issues/4#issuecomment-1234" class="ref-issue">person/repo#4 (comment)</a>`)
+
+	// special tags, GitHub's behavior
+	test("<script>a</script><style>b</style>", `&lt;script&gt;a&lt;/script&gt;&lt;style&gt;b&lt;/style&gt;`)
+	// unclosed tags, output as text content as much as possible
+	test("<script>a", `&lt;script&gt;a&lt;/body&gt;&lt;/html&gt;&lt;/script&gt;`)
 }
 
 func TestIssue16020(t *testing.T) {