Skip to content

"Quickstart for Actions Runner Controller" recommends using a legacy user PAT for setting up ARC, which is poor practice #37288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
paul-civitas opened this issue Apr 3, 2025 · 6 comments
Labels
content This issue or pull request belongs to the Docs Content team github_actions Pull requests that update GitHub Actions code help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR

Comments

@paul-civitas
Copy link

Code of Conduct

What article on docs.github.com. is affected?

https://github.com./github/docs/blob/main/content/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/deploying-runner-scale-sets-with-actions-runner-controller.md

What part(s) of the article would you like to see updated?

Reading the helm values for the gha-runner-scale-set chart, the helm chart supports authenticating via github app, which is a more secure and production grade method of configuring ARC than using a user's personal access token.

The docs should be updated to nudge people towards the more proper way of doing things.

Additional information

I know github is trying to phase out classic PATs so it was unexpected to see official docs instructing to use a PAT, especially when other methods are supported.

@paul-civitas paul-civitas added the content This issue or pull request belongs to the Docs Content team label Apr 3, 2025
Copy link

welcome bot commented Apr 3, 2025

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 3, 2025
@Sharra-writes
Copy link
Contributor

Thanks so much for opening an issue! I'll get this triaged for review.

@Sharra-writes Sharra-writes added actions This issue or pull request should be reviewed by the docs actions team github_actions Pull requests that update GitHub Actions code and removed triage Do not begin working on this issue until triaged by the team actions This issue or pull request should be reviewed by the docs actions team labels Apr 3, 2025
@brambhattabhishek

This comment has been minimized.

@Sharra-writes Sharra-writes added the needs SME This proposal needs review from a subject matter expert label Apr 8, 2025
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

@Sharra-writes
Copy link
Contributor

@paul-civitas Looking into this, it appears there is room to make this documentation better. If you or anyone else want to open a PR to improve it, we would appreciate the help. 💛

@Sharra-writes Sharra-writes added help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR and removed needs SME This proposal needs review from a subject matter expert labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team github_actions Pull requests that update GitHub Actions code help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

No branches or pull requests

4 participants
@paul-civitas @brambhattabhishek @Sharra-writes and others