-
Notifications
You must be signed in to change notification settings - Fork 1
/
Copy pathwrapperFunctions.go
105 lines (77 loc) · 1.51 KB
/
wrapperFunctions.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
package minioExtensions
func success() bool {
return errorSource() == ErrNone
}
func failure() bool {
return errorSource() != ErrNone
}
func succeeded(ret int) bool {
return ret == ErrNone
}
func failed(ret int) bool {
return ret != ErrNone
}
func thenBranchGoodSourceWrapper() {
if failure() {
// Good: an error means we return early
return
}
doSomething()
}
func thenBranchBadSourceWrapper() {
if failure() {
// Bad: despite an error, we carry on to execute doSomething()
insteadOfReturn()
}
doSomething()
}
func elseBranchGoodSourceWrapper() {
if success() {
doSomething()
} else {
// Good: an error means we return early
return
}
doSomething()
}
func elseBranchBadSourceWrapper() {
if success() {
doSomething()
} else {
// Bad: despite an error, we carry on to execute doSomething()
insteadOfReturn()
}
doSomething()
}
func thenBranchGoodTestWrapper() {
if failed(errorSource()) {
// Good: an error means we return early
return
}
doSomething()
}
func thenBranchBadTestWrapper() {
if failed(errorSource()) {
// Bad: despite an error, we carry on to execute doSomething()
insteadOfReturn()
}
doSomething()
}
func elseBranchGoodTestWrapper() {
if succeeded(errorSource()) {
doSomething()
} else {
// Good: an error means we return early
return
}
doSomething()
}
func elseBranchBadTestWrapper() {
if succeeded(errorSource()) {
doSomething()
} else {
// Bad: despite an error, we carry on to execute doSomething()
insteadOfReturn()
}
doSomething()
}