Skip to content

Commit a0d27ac

Browse files
committed
chore: fix failing unit tests
1 parent eab7e7e commit a0d27ac

File tree

2 files changed

+24
-23
lines changed

2 files changed

+24
-23
lines changed

src/app/modules/angular-slickgrid/components/__tests__/angular-slickgrid.component.spec.ts

+8-5
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
jest.mock('@slickgrid-universal/common/dist/commonjs/formatters/formatterUtilities');
21
import 'jest-extended';
32
import { ApplicationRef, ChangeDetectorRef, ElementRef } from '@angular/core';
43
import { TestBed } from '@angular/core/testing';
54
import { TranslateService, TranslateModule } from '@ngx-translate/core';
65
import {
6+
autoAddEditorFormatterToColumnsWithEditor,
77
BackendService,
88
BackendServiceApi,
99
BackendUtilityService,
@@ -39,7 +39,6 @@ import {
3939
TreeDataService,
4040
SlickGroupItemMetadataProvider
4141
} from '@slickgrid-universal/common';
42-
import * as formatterUtilities from '@slickgrid-universal/common/dist/commonjs/formatters/formatterUtilities';
4342
import { SlickFooterComponent } from '@slickgrid-universal/custom-footer-component';
4443
import { EventPubSubService } from '@slickgrid-universal/event-pub-sub';
4544
import { SlickEmptyWarningComponent } from '@slickgrid-universal/empty-warning-component';
@@ -54,6 +53,11 @@ import { GridOption } from '../../models';
5453
import { MockSlickEvent, MockSlickEventHandler } from '../../../../../../test/mockSlickEvent';
5554
import { RxJsResourceStub } from '../../../../../../test/rxjsResourceStub';
5655

56+
jest.mock('@slickgrid-universal/common', () => ({
57+
...(jest.requireActual('@slickgrid-universal/common') as any),
58+
autoAddEditorFormatterToColumnsWithEditor: jest.fn(),
59+
}));
60+
5761
declare const Slick: any;
5862
const slickEventHandler = new MockSlickEventHandler();
5963
jest.mock('flatpickr', () => { });
@@ -538,7 +542,7 @@ describe('Angular-Slickgrid Custom Component instantiated via Constructor', () =
538542
component.ngAfterViewInit();
539543

540544
expect(component).toBeTruthy();
541-
// expect(formatterUtilities.autoAddEditorFormatterToColumnsWithEditor).toHaveBeenCalledWith([{ id: 'name', field: 'name', editor: undefined, internalColumnEditor: {} }], customEditableInputFormatter);
545+
expect(autoAddEditorFormatterToColumnsWithEditor).toHaveBeenCalledWith([{ id: 'name', field: 'name', editor: undefined, internalColumnEditor: {} }], customEditableInputFormatter);
542546
});
543547
});
544548

@@ -565,7 +569,6 @@ describe('Angular-Slickgrid Custom Component instantiated via Constructor', () =
565569
const autosizeSpy = jest.spyOn(mockGrid, 'autosizeColumns');
566570
const updateSpy = jest.spyOn(component, 'updateColumnDefinitionsList');
567571
const renderSpy = jest.spyOn(extensionServiceStub, 'renderColumnHeaders');
568-
const autoAddFormatterSpy = jest.spyOn(formatterUtilities, 'autoAddEditorFormatterToColumnsWithEditor');
569572
const mockColDefs = [{ id: 'name', field: 'name', editor: undefined, internalColumnEditor: {} }];
570573

571574
component.ngAfterViewInit();
@@ -577,7 +580,7 @@ describe('Angular-Slickgrid Custom Component instantiated via Constructor', () =
577580
expect(autosizeSpy).toHaveBeenCalled();
578581
expect(updateSpy).toHaveBeenCalledWith(mockColDefs);
579582
expect(renderSpy).toHaveBeenCalledWith(mockColDefs, true);
580-
// expect(autoAddFormatterSpy).toHaveBeenCalledWith([{ id: 'name', field: 'name', editor: undefined, internalColumnEditor: {} }], customEditableInputFormatter);
583+
expect(autoAddEditorFormatterToColumnsWithEditor).toHaveBeenCalledWith([{ id: 'name', field: 'name', editor: undefined, internalColumnEditor: {} }], customEditableInputFormatter);
581584
});
582585
});
583586

src/app/modules/angular-slickgrid/extensions/__tests__/slickRowDetailView.spec.ts

+16-18
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { ApplicationRef, Component } from '@angular/core';
2-
import { Column, OnSelectedRowsChangedEventArgs, SharedService, SlickEventHandler, SlickGrid, SlickNamespace, } from '@slickgrid-universal/common';
2+
import { Column, OnSelectedRowsChangedEventArgs, SharedService, SlickEventHandler, SlickGrid, SlickNamespace, SlickRowSelectionModel, } from '@slickgrid-universal/common';
33
import { EventPubSubService } from '@slickgrid-universal/event-pub-sub';
4-
import { SlickRowSelectionModel } from '@slickgrid-universal/common/dist/commonjs/extensions/slickRowSelectionModel';
54
import { of } from 'rxjs';
65

76
import { GridOption } from '../../models/gridOption.interface';
@@ -11,6 +10,21 @@ import { RxJsResourceStub } from '../../../../../../test/rxjsResourceStub';
1110
import { SlickRowDetailView } from '../slickRowDetailView';
1211
jest.mock('@slickgrid-universal/row-detail-view-plugin');
1312

13+
jest.mock('@slickgrid-universal/common', () => ({
14+
...(jest.requireActual('@slickgrid-universal/common') as any),
15+
SlickRowSelectionModel: jest.fn().mockImplementation(() => ({
16+
constructor: jest.fn(),
17+
init: jest.fn(),
18+
destroy: jest.fn(),
19+
dispose: jest.fn(),
20+
getSelectedRows: jest.fn(),
21+
setSelectedRows: jest.fn(),
22+
getSelectedRanges: jest.fn(),
23+
setSelectedRanges: jest.fn(),
24+
onSelectedRangesChanged: new Slick.Event(),
25+
})),
26+
}));
27+
1428
declare const Slick: SlickNamespace;
1529
const ROW_DETAIL_CONTAINER_PREFIX = 'container_';
1630
const PRELOAD_CONTAINER_PREFIX = 'container_loading';
@@ -67,22 +81,6 @@ const gridStub = {
6781
onSort: new Slick.Event(),
6882
} as unknown as SlickGrid;
6983

70-
const mockRowSelectionModel = {
71-
constructor: jest.fn(),
72-
init: jest.fn(),
73-
destroy: jest.fn(),
74-
dispose: jest.fn(),
75-
getSelectedRows: jest.fn(),
76-
setSelectedRows: jest.fn(),
77-
getSelectedRanges: jest.fn(),
78-
setSelectedRanges: jest.fn(),
79-
onSelectedRangesChanged: new Slick.Event(),
80-
} as unknown as SlickRowSelectionModel;
81-
82-
jest.mock('@slickgrid-universal/common/dist/commonjs/extensions/slickRowSelectionModel', () => ({
83-
SlickRowSelectionModel: jest.fn().mockImplementation(() => mockRowSelectionModel),
84-
}));
85-
8684
@Component({ template: `<h4>Loading...</h4>` })
8785
class TestPreloadComponent { }
8886

0 commit comments

Comments
 (0)