Skip to content

Unify console instrumentation #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AbhiPrasad opened this issue Feb 9, 2022 · 1 comment · Fixed by #16024
Closed

Unify console instrumentation #4532

AbhiPrasad opened this issue Feb 9, 2022 · 1 comment · Fixed by #16024
Assignees
Labels
hacktoberfest Meta: Help Wanted Package: core Issues related to the Sentry Core SDK

Comments

@AbhiPrasad
Copy link
Member

The console instrumentation in the SDK seem to duplicate code. Maybe we can find a way to unify them? We can also improve testing this way, and it may help save bundle size.

the instrumentConsole utility:

function instrumentConsole(): void {

the node Console integration: https://github.com./getsentry/sentry-javascript/blob/master/packages/node/src/integrations/console.ts

the CaptureConsole integration: https://github.com./getsentry/sentry-javascript/blob/master/packages/integrations/src/captureconsole.ts

Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #16024, which was included in the 9.13.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Meta: Help Wanted Package: core Issues related to the Sentry Core SDK
Projects
None yet
2 participants