Skip to content

SDK sends query params and fragment in span description of http.client spans #15360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
Lms24 opened this issue Feb 10, 2025 · 1 comment · Fixed by #15404
Closed
3 tasks done

SDK sends query params and fragment in span description of http.client spans #15360

Lms24 opened this issue Feb 10, 2025 · 1 comment · Fixed by #15404
Assignees
Labels
Package: browser Issues related to the Sentry Browser SDK

Comments

@Lms24
Copy link
Member

Lms24 commented Feb 10, 2025

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/core, still need to check if also a problem in Otel-based SDKs

SDK Version

v8, v9

Framework Version

N/A

Link to Sentry event

No response

Reproduction Example/SDK Setup

Default SDK setup w/ tracing

Steps to Reproduce

await fetch(/api/users?id=123);

Expected Result

an op: http.client span with GET /api/users as span name/description

Actual Result

an op: http.client span with GET /api/users?id=123 as span name/description

Notes

Worth mentioning that this used to work already and we had integration tests that covered this. For some reason we must have removed them in the v8 process. Part of this issue is investigating why we removed them, and how we can prevent something like this going forward.

@github-actions github-actions bot added the Package: browser Issues related to the Sentry Browser SDK label Feb 10, 2025
@Lms24 Lms24 self-assigned this Feb 10, 2025
@Lms24 Lms24 changed the title Regression: SDK sends query params and fragment in span description of http.client spans SDK sends query params and fragment in span description of http.client spans Feb 10, 2025
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #15404, which was included in the 9.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: browser Issues related to the Sentry Browser SDK
Projects
None yet
1 participant