Skip to content

Commit d773cb7

Browse files
authored
feat!: Remove metrics API from the JS SDK (#14745)
1. Removes `metrics` export and all it's usages 2. Removes all usages of `_metrics_summary` from the SDK 3. Removes `metricsShim` usage in the browser SDK CDN bundles 4. Removes all metrics related types from the SDK
1 parent a921440 commit d773cb7

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+7
-2261
lines changed

Diff for: dev-packages/browser-integration-tests/suites/metrics/metricsEvent/init.js

-34
This file was deleted.

Diff for: dev-packages/browser-integration-tests/suites/metrics/metricsEvent/test.ts

-34
This file was deleted.

Diff for: dev-packages/browser-integration-tests/suites/metrics/metricsShim/init.js

-13
This file was deleted.

Diff for: dev-packages/browser-integration-tests/suites/metrics/metricsShim/test.ts

-36
This file was deleted.

Diff for: dev-packages/browser-integration-tests/suites/metrics/timing/init.js

-39
This file was deleted.

Diff for: dev-packages/browser-integration-tests/suites/metrics/timing/test.ts

-159
This file was deleted.

Diff for: dev-packages/browser-integration-tests/utils/helpers.ts

-12
Original file line numberDiff line numberDiff line change
@@ -270,18 +270,6 @@ export function shouldSkipFeedbackTest(): boolean {
270270
return false;
271271
}
272272

273-
/**
274-
* We can only test metrics tests in certain bundles/packages:
275-
* - NPM (ESM, CJS)
276-
* - CDN bundles that include tracing
277-
*
278-
* @returns `true` if we should skip the metrics test
279-
*/
280-
export function shouldSkipMetricsTest(): boolean {
281-
const bundle = process.env.PW_BUNDLE as string | undefined;
282-
return bundle != null && !bundle.includes('tracing') && !bundle.includes('esm') && !bundle.includes('cjs');
283-
}
284-
285273
/**
286274
* We only test feature flags integrations in certain bundles/packages:
287275
* - NPM (ESM, CJS)

Diff for: dev-packages/node-integration-tests/suites/metrics/should-exit-forced.js

-19
This file was deleted.

Diff for: dev-packages/node-integration-tests/suites/metrics/should-exit.js

-18
This file was deleted.

0 commit comments

Comments
 (0)