Skip to content

Commit a551e39

Browse files
authored
ci: Add node 9 and 10 to travis builds (#456)
* ci: Add node 9 and 10 to travis builds * test: Fix listeners test for Node >= 9
1 parent 1e44061 commit a551e39

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

.travis.yml

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ node_js:
66
- "6"
77
- "7"
88
- "8"
9+
- "9"
10+
- "10"
911

1012
cache:
1113
directories:

test/raven.client.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,11 @@ describe('raven.Client', function() {
514514

515515
client.install();
516516

517-
listeners = process.listeners('uncaughtException');
517+
// Since Node v9, any listener will be prepended with domain specific listener and it cannot be altered
518+
// https://github.com./nodejs/node/blob/ca41a30afa825373f2711a46965dfd4ca4a4ca3a/lib/domain.js#L146-L170
519+
listeners = process.listeners('uncaughtException').filter(function(listener) {
520+
return listener.name !== 'domainUncaughtExceptionClear';
521+
});
518522
listeners.length.should.equal(1);
519523
});
520524

0 commit comments

Comments
 (0)