Skip to content

Commit 5451cd4

Browse files
Pajnfacebook-github-bot
authored andcommitted
fix: Crash if WebView is disabled (#34483)
Summary: When the webview is updated by play store, all apps that has loaded webview gets killed. For background see https://issuetracker.google.com/issues/228611949?pli=1 We have a long-running app and don't want this to happen and while we are not using webview anywhere, we are using websockets that loads it for reading cookies, however we are not using cookies to authenticate the websocket and thus want to disable the webview to avoid loading it unnecessarily and then getting killed unnecessarily. The webview has support for beeing disabled https://developer.android.com/reference/android/webkit/WebView#disableWebView() however as-is this crashes React Native. It seems to me like this case is very similar to not having web view installed and should be handled in the same way. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Fixed] - Avoid crash in ForwardingCookieHandler if webview is disabled Pull Request resolved: #34483 Test Plan: Add `WebView.disableWebView();` as the first line in `MainActivity.onCreate`. Reviewed By: christophpurrer Differential Revision: D38981827 Pulled By: cipolleschi fbshipit-source-id: 335a8420568ad0c80b834ae8a3b164e55ebe26f3
1 parent 4f486c7 commit 5451cd4

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

ReactAndroid/src/main/java/com/facebook/react/modules/network/ForwardingCookieHandler.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,9 @@ protected void doInBackgroundGuarded(Void... params) {
152152
|| (message != null
153153
&& (message.contains("WebView provider")
154154
|| message.contains("No WebView installed")
155-
|| message.contains("Cannot load WebView")))) {
155+
|| message.contains("Cannot load WebView")
156+
|| message.contains("disableWebView")
157+
|| message.contains("WebView is disabled")))) {
156158
return null;
157159
} else {
158160
throw exception;

0 commit comments

Comments
 (0)