Skip to content

Typo in eagle_soc.h ? #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gdhgdhgdh opened this issue Feb 29, 2016 · 2 comments
Closed

Typo in eagle_soc.h ? #1705

gdhgdhgdh opened this issue Feb 29, 2016 · 2 comments

Comments

@gdhgdhgdh
Copy link

gdhgdhgdh commented Feb 29, 2016

Please excuse any naivety!

In https://github.com./esp8266/Arduino/blob/master/tools/sdk/include/eagle_soc.h#L151-L153 should these three lines not be using PERIPHS_RTC_BASEADDR instead of PERIPHS_TIMER_BASEDDR ?

Cheers,
Gavin.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@igrr
Copy link
Member

igrr commented Mar 1, 2016

I think these should be TIMER_REG_READ, TIMER_REG_WRITE, etc., because later on there is #define NOW() which reads the value of timer 2 count register. So it's probably a typo, but not in *_BASEADDR, but in define name.

@devyte
Copy link
Collaborator

devyte commented Oct 18, 2017

I agree with @igrr, I think the names are just wrong.
They correct ones should be defined, and these should be deprecated most likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants