AddServiceTxt returning bool (issue #1962) (#4507)

fabianoms · devyte · commit 4e2e1f268cca · 2018-03-17T20:16:26.000-03:00
diff --git a/libraries/ESP8266mDNS/ESP8266mDNS.h b/libraries/ESP8266mDNS/ESP8266mDNS.h
@@ -81,11 +81,11 @@ class MDNSResponder {
   }
   
   bool addServiceTxt(char *name, char *proto, char * key, char * value);
-  void addServiceTxt(const char *name, const char *proto, const char *key,const char * value){
-    addServiceTxt((char *)name, (char *)proto, (char *)key, (char *)value);
+  bool addServiceTxt(const char *name, const char *proto, const char *key,const char * value){
+    return addServiceTxt((char *)name, (char *)proto, (char *)key, (char *)value);
   }
-  void addServiceTxt(String name, String proto, String key, String value){
-    addServiceTxt(name.c_str(), proto.c_str(), key.c_str(), value.c_str());
+  bool addServiceTxt(String name, String proto, String key, String value){
+    return addServiceTxt(name.c_str(), proto.c_str(), key.c_str(), value.c_str());
   }
   
   int queryService(char *service, char *proto);

Original file line number	Diff line number	Diff line change
`@@ -81,11 +81,11 @@ class MDNSResponder {`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`bool addServiceTxt(char name, char proto, char * key, char * value);`
`84`		`- void addServiceTxt(const char name, const char proto, const char key,const char value){`
`85`		`- addServiceTxt((char )name, (char )proto, (char )key, (char )value);`
	`84`	`+ bool addServiceTxt(const char name, const char proto, const char key,const char value){`
	`85`	`+ return addServiceTxt((char )name, (char )proto, (char )key, (char )value);`
`86`	`86`	`}`
`87`		`- void addServiceTxt(String name, String proto, String key, String value){`
`88`		`- addServiceTxt(name.c_str(), proto.c_str(), key.c_str(), value.c_str());`
	`87`	`+ bool addServiceTxt(String name, String proto, String key, String value){`
	`88`	`+ return addServiceTxt(name.c_str(), proto.c_str(), key.c_str(), value.c_str());`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`int queryService(char service, char proto);`