Skip to content

Fix current session ip address visibility (PSG-1109) #7794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

onurays
Copy link
Contributor

@onurays onurays commented Dec 15, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

We had a bug on current session details screen. Even if user selects "Show IP address" menu item it is not shown because we accidentally depend it to "last activity time" flag. This PR solves the problem by separating activity and ip address flags.

Motivation and context

Fix UX review remarks.

Screenshots / GIFs

Tests

  • Enable new session manager from Labs settings
  • Navigate to Settings > Security & Privacy -> Show all sessions
  • Select "view session details" on current session card
  • Select "Show/Hide IP address" menu item

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@onurays onurays requested review from a team and ganfra and removed request for a team December 15, 2022 14:33
@ElementBot
Copy link

Fails
🚫

node failed.

Log

Error:  Error: Could not find the Dangerfile at ./tools/danger/dangerfile-lint.js - does a file exist at danger/dangerfile-lint.js in ./tools?.
    at /usr/src/danger/distribution/platforms/GitHub.js:166:27
    at step (/usr/src/danger/distribution/platforms/GitHub.js:44:23)
    at Object.next (/usr/src/danger/distribution/platforms/GitHub.js:25:53)
    at fulfilled (/usr/src/danger/distribution/platforms/GitHub.js:16:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
danger-results://tmp/danger-results-6d76da87.json

Generated by 🚫 dangerJS against a213338

@ElementBot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 61685d3

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@onurays onurays merged commit f08a3f7 into develop Dec 19, 2022
@onurays onurays deleted the feature/ons/fix_current_session_ip_address_visibility branch December 19, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants