Remind unverified sessions with a banner once a week (PSG-892) #7694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurays
requested review from
a team and
jmartinesp
and removed request for
a team
ElementBot
reviewed
Dec 2, 2022
| <string name="review_logins">Review where you’re logged in</string> | ||
| <!-- TODO TO BE REMOVED --> | ||
| <string name="verify_other_sessions">Verify all your sessions to ensure your account & messages are safe</string> |
There was a problem hiding this comment.
- 🚫 The resource
R.string.review_loginsappears to be unused
| <string name="verify_other_sessions">Verify all your sessions to ensure your account & messages are safe</string> | ||
| <string name="review_unverified_sessions_title">You have unverified sessions</string> | ||
| <string name="review_unverified_sessions_description">Review to ensure your account is safe</string> |
There was a problem hiding this comment.
- 🚫 The resource
R.string.verify_other_sessionsappears to be unused
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Currently, we never remind users about their unverified sessions once the alert banner is dismissed. We want to remind users to review unverified sessions in a certain period.
Motivation and context
When we detect a new login on another device, we are showing a "New Login" banner on verified devices. If the user dismisses it we need to show "Review your logins" banners to the user. If the user dismisses this banner too, then we don't show a banner for a while (1 week in current config).
Screenshots / GIFs
Tests
Config.SHOW_UNVERIFIED_SESSIONS_ALERT_AFTER_MILLIS = 60_000for test purposesTested devices
Checklist