Skip to content

[Rich text editor] Fix design and spacing of rich text editor #7658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Nov 29, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Improve design and spacing of the rich text editor.

Minor changes to

  • position of input field relative to buttons
  • spacing around attachments button
  • spacing around send button
  • selectable backgrounds

Motivation and context

https://element-io.atlassian.net/browse/PSU-994

Screenshots / GIFs

Before After
Empty input, formatting disabled rich-text-formatting-disabled-before rich-text-formatting-disabled
Empty input, formatting enabled rich-text-formatting-enabled-before rich-text-formatting-enabled
Text in input, formatting disabled rich-text-formatting-disabled-send-before rich-text-formatting-disabled-send
Text in input, formatting enabled rich-text-formatting-enabled-send-before rich-text-formatting-enabled-send

Tests

  1. Enable rich text editor (via labs)
  2. Navigate to a room
  3. Enable text formatting (via the attachment menu)
  4. Check design
  5. Disable text formatting (via the attachment menu)
  6. Check design

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13

Checklist

@jonnyandrew jonnyandrew changed the title [Rich text editor] Improve design and spacing of rich text editor [Rich text editor] Fix design and spacing of rich text editor Nov 29, 2022
@jonnyandrew jonnyandrew marked this pull request as ready for review November 29, 2022 13:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jonnyandrew jonnyandrew requested review from a team and mnaturel and removed request for a team November 29, 2022 14:17
Copy link
Contributor

@mnaturel mnaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants