Skip to content

ANR when asking to select the notification method #7653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mnaturel opened this issue Nov 28, 2022 · 0 comments · Fixed by #7675
Closed

ANR when asking to select the notification method #7653

mnaturel opened this issue Nov 28, 2022 · 0 comments · Fixed by #7675
Assignees
@mnaturel
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-ANR Application Not Responding Z-UnifiedPush

Comments

@mnaturel
Copy link
Contributor

Steps to reproduce

When asking to select a notification method (background sync or unified push), it leads to ANR since the code is running on Main thread.

Another issue is the check of the notification method is done in the renderState() method in HomeActivity which should not be done there since this is not UI. It leads to have multiple displayed dialog at start.

Also to have better code architecture, this related code should be encapsulated into a dedicated UseCase.

Outcome

What did you expect?

To not experience ANR.

What happened instead?

ANR + strange behavior on startup of the home screen.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely Z-ANR Application Not Responding Z-UnifiedPush labels Nov 28, 2022
@mnaturel mnaturel self-assigned this Nov 28, 2022
This was referenced Nov 28, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-ANR Application Not Responding Z-UnifiedPush
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ANR when asking to select the notification method element-hq/element-android
1 participant
@mnaturel