Fix crash by disabling Flipper on API 22 and below

[jonnyandrew]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Disable Flipper on API 22 and below as it causes a crash immediately on app startup.

Motivation and context

• See the related issue: dlopen failed libflipper.so... facebook/flipper#3572

Screenshots / GIFs

N/A

Tests

• Launch the app on an emulator running Android 5
• Observe no crash

Tested devices

• Physical
• Emulator
• OS version(s): 21

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com./vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com./vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[jmartinesp]

The code LGTM, let's see if we can make the checks pass.

[jmartinesp]

Danger seems to be failing consistently. Maybe it's because @jonnyandrew is in the orgs but still doesn't have write access to this repo for some reason?

[bmarty]

LGTM, some remarks though.

[bmarty]

Why this is not done above the line SoLoader.init(context, false)?

Also I would also update the fun networkInterceptor() to return null if Build.VERSION.SDK_INT <= Build.VERSION_CODES.LOLLIPOP_MR1

[jonnyandrew]

I put it here to keep this logic at the same point as the existing check (on the line immediately after this one).

In the docs SoLoader.init() is always called regardless of whether Flipper is enabled but I'm not sure if there's any reason for that.

The same is true of the networkInterceptor() but I'd agree, it should return null if Flipper is disabled.

[jonnyandrew]

5425622

[bmarty]

Not a big deal, but creating on object for nothing is a bit weird. I would change to

override fun networkInterceptor() = if (isEnabled) FlipperOkhttpInterceptor(networkFlipperPlugin) else null

[jonnyandrew]

1080740

[jonnyandrew]

Agreed - and takeIf is not very readable either 👍

[bmarty]

Thanks for the update.

[bmarty]

Danger seems to be failing consistently. Maybe it's because @jonnyandrew is in the orgs but still doesn't have write access to this repo for some reason?

I will check the repo settings.

@jonnyandrew can you add yourself in this list? You can do it in this PR, this is fine.

[bmarty]

Thanks!