Skip to content

Make Lao language available in the in app setting. #6196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2022
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 31, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : new language added

Content

Lao translations are quite new. If the locale of the device is set to Lao, the translations will be used. This PR adds what's necessary to add this local to the in app language setting, so it's now possible to force using Lao.

Motivation and context

Screenshots / GIFs

Before After
image image

Tests

  • Go to setting/Preferences/Language and select Lao. Observe that the UI is now displayed in Lao.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested review from a team, Florian14 and Claire1817 and removed request for a team May 31, 2022 07:57
@bmarty bmarty added the PR-Small PR with less than 20 updated lines label May 31, 2022

<string name="resources_language">lo</string>
<string name="resources_country_code">LA</string>
<string name="resources_script">Laoo</string>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label May 31, 2022
@github-actions
Copy link

Unit Test Results

142 files  ±0  142 suites  ±0   2m 19s ⏱️ -11s
229 tests ±0  229 ✔️ ±0  0 💤 ±0  0 ±0 
760 runs  ±0  760 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 9ed62ac. ± Comparison against base commit 483b1ab.

@bmarty bmarty merged commit 3cc1951 into develop May 31, 2022
@bmarty bmarty deleted the feature/bma/lao branch May 31, 2022 09:42
@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    = passed=20 failures=0 errors=0 skipped=3
  • [org.matrix.android.sdk.account]
    = passed=3 failures=0 errors=0 skipped=2
  • [org.matrix.android.sdk.internal]
    = passed=3 failures=0 errors=0 skipped=2
  • [org.matrix.android.sdk.ordering]
    = passed=16 failures=0 errors=0 skipped=0
  • [org.matrix.android.sdk.PermalinkParserTest]
    = passed=2 failures=0 errors=0 skipped=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Small PR with less than 20 updated lines Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants