Skip to content

Fix some cases where the read marker line would not show up when it should #5475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2022

Conversation

SpiritCroc
Copy link
Contributor

@SpiritCroc SpiritCroc commented Mar 9, 2022

Signed-off-by: Tobias Büttner [email protected]

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Tests

  1. Permalink the latest message in a chat
  2. Close the chat
  3. Receive lots of messages
  4. Open the chat at the permalink and see if the unread messages line shows up

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

Case: bottom-most loaded event has read marker, but there are messages below it
that haven't been loaded yet.
HasUnread might not be correct on the first try while loading the
timeline.
@SpiritCroc SpiritCroc marked this pull request as draft March 21, 2022 10:13
@SpiritCroc SpiritCroc marked this pull request as ready for review March 21, 2022 18:55
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Apr 7, 2022
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@ganfra ganfra merged commit 53c7cec into element-hq:develop Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants