Skip to content

Change Green bar to Grey on Room list #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniellekirkwood opened this issue Dec 6, 2021 · 5 comments
Closed

Change Green bar to Grey on Room list #4639

daniellekirkwood opened this issue Dec 6, 2021 · 5 comments
Assignees
Labels
A-Room-List T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Dec 6, 2021

This issue is: Ready to build

Problem

There's a lot of green in our app, it's startling to new users as its not always clear what green means. This is especially prevalent in the Room and DMs list when the left hand side could be straight green...

Solution

Change the green bar to grey

For light mode: #737D8C
For dark mode: #A9B2BC

See screenshot below

Note there are 2 different shades of grey on iOS. A dark one for general unread messages and a light one for notifications. Do we want to keep the grey this way around and do we want to replicate the same on Android that we have on iOS?

@daniellekirkwood daniellekirkwood added X-Needs-Design May require input from the design team T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF moment: High Impact, Low Effort labels Dec 6, 2021
@amshakal
Copy link

amshakal commented Dec 15, 2021

Here is what we have on iOS currently:
IMG_6B8FB0212B7F-1

Here is what we have on android currently:
Screenshot_20211126-155450

Can we change the left bar colour to that on iOS?
For light mode: #737D8C
For dark mode: #A9B2BC

Note:

  • the icon representing the number of notifications should be of the same colour as above. If it's not, I think we should change it for consistency.
  • I also think having the notification badge fixed to the right next to timestamp is less disruptive. Consider making that change as well.

@amshakal
Copy link

We have an issue for that already :) #4640

@daniellekirkwood
Copy link
Contributor Author

@amshakal there are 2 different shades of grey on iOS. A dark one for general unread messages and a light one for notifications. Do we want to keep the grey this way around and do we want to replicate the same on Android that we have on iOS?

@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Feb 2, 2022
@daniellekirkwood
Copy link
Contributor Author

Let's keep the gray as is for now, we can re-assess in time.

@bmarty
Copy link
Member

bmarty commented Feb 22, 2022

Fixed in 1.4.2

@bmarty bmarty closed this as completed Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort
Projects
None yet
Development

No branches or pull requests

4 participants