Skip to content

Link to contact detail sharing policy doesn't work #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kittykat opened this issue Oct 27, 2021 · 5 comments
Open

Link to contact detail sharing policy doesn't work #4356

kittykat opened this issue Oct 27, 2021 · 5 comments
Labels
A-3PIDs O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Privacy T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team X-Needs-Product Issue needs input from Product team Z-Confidence-High High confidence in the enhancement or suggestion based on known factors, or as described.

Comments

@kittykat
Copy link
Contributor

Steps to reproduce

  1. Left panel -> Settings -> General
  2. Discovery
  3. Give consent
  4. Policy

Intended result and actual result

What did you expect?

To see the policy

What happened instead?

Dialog closed

S-Critical because there's no workaround, O-Frequent because it happens to every user who wants to find their contacts.

Your phone model

No response

Operating system version

Android 11

Application version and app store

App store

Homeserver

matrix.org

Will you send logs?

No

@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Privacy A-3PIDs S-Critical Prevents work, causes data loss and/or has no workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Oct 27, 2021
@kittykat kittykat changed the title Link to privacy policy doesn't work Link to contact detail sharing policy doesn't work Oct 27, 2021
@bmarty
Copy link
Member

bmarty commented Oct 28, 2021

Actually it has an effect, but this is not obvious: the policy section (in the same screen) get expanded in this case.
Maybe we can improve that by scrolling to the section, or highlight it?
Also if there is only one policy, you may be able to also open it directly

@kittykat
Copy link
Contributor Author

Ah, I see! When I've scrolled down to "give consent", my screen doesn't change at all if I click "Policy"

I think that ideally, "policy" should open the web page with the privacy policy.

If it's important for it to not do that and link to the "identity server policy" collapsible section, then I would expect the link "Policy" and the associated policy in the list ("Privacy Notice") to have the same name, for the view to scroll to that area and for the correct link to be highlighted so it's more visible.

@ouchadam
Copy link
Contributor

original implementation for reference #4184

@bmarty
Copy link
Member

bmarty commented Oct 28, 2021

I think that ideally, "policy" should open the web page with the privacy policy.

We can have a list of URLs here.

@ouchadam
Copy link
Contributor

switching from critical defect to an enhancement, the policies urls are available but with a non optimal UX flow

CURRENT UX
after-policy-link

@ouchadam ouchadam added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team X-Needs-Product Issue needs input from Product team and removed T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Critical Prevents work, causes data loss and/or has no workaround labels Nov 16, 2021
@nadonomy nadonomy added the Z-Confidence-High High confidence in the enhancement or suggestion based on known factors, or as described. label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-3PIDs O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Privacy T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team X-Needs-Product Issue needs input from Product team Z-Confidence-High High confidence in the enhancement or suggestion based on known factors, or as described.
Projects
None yet
Development

No branches or pull requests

4 participants