Skip to content

Commit f5634ba

Browse files
committed
a11y fixes
1 parent 20ca249 commit f5634ba

File tree

2 files changed

+21
-18
lines changed

2 files changed

+21
-18
lines changed

vector/src/main/res/layout/fragment_space_preview.xml

+19-18
Original file line numberDiff line numberDiff line change
@@ -16,32 +16,33 @@
1616
style="@style/VectorToolbarStyle"
1717
android:layout_width="match_parent"
1818
android:layout_height="?actionBarSize"
19-
app:navigationIcon="@drawable/ic_x_18dp"
20-
android:elevation="4dp">
19+
android:elevation="4dp"
20+
app:navigationIcon="@drawable/ic_x_18dp">
2121

2222
<androidx.constraintlayout.widget.ConstraintLayout
2323
android:layout_width="match_parent"
2424
android:layout_height="match_parent">
2525

26-
<!-- <ImageView-->
27-
<!-- android:id="@+id/spacePreviewClose"-->
28-
<!-- android:layout_width="@dimen/layout_touch_size"-->
29-
<!-- android:layout_height="@dimen/layout_touch_size"-->
30-
<!-- android:clickable="true"-->
31-
<!-- android:focusable="true"-->
32-
<!-- android:foreground="?attr/selectableItemBackground"-->
33-
<!-- android:scaleType="center"-->
34-
<!-- android:src="@drawable/ic_x_18dp"-->
35-
<!-- app:layout_constraintBottom_toBottomOf="parent"-->
36-
<!-- app:layout_constraintStart_toStartOf="parent"-->
37-
<!-- app:layout_constraintTop_toTopOf="parent" />-->
26+
<!-- <ImageView-->
27+
<!-- android:id="@+id/spacePreviewClose"-->
28+
<!-- android:layout_width="@dimen/layout_touch_size"-->
29+
<!-- android:layout_height="@dimen/layout_touch_size"-->
30+
<!-- android:clickable="true"-->
31+
<!-- android:focusable="true"-->
32+
<!-- android:foreground="?attr/selectableItemBackground"-->
33+
<!-- android:scaleType="center"-->
34+
<!-- android:src="@drawable/ic_x_18dp"-->
35+
<!-- app:layout_constraintBottom_toBottomOf="parent"-->
36+
<!-- app:layout_constraintStart_toStartOf="parent"-->
37+
<!-- app:layout_constraintTop_toTopOf="parent" />-->
3838

3939
<ImageView
4040
android:id="@+id/spacePreviewToolbarAvatar"
4141
android:layout_width="40dp"
4242
android:layout_height="40dp"
4343
android:layout_marginTop="8dp"
4444
android:layout_marginBottom="8dp"
45+
android:contentDescription="@string/avatar"
4546
app:layout_constraintBottom_toBottomOf="parent"
4647
app:layout_constraintStart_toStartOf="parent"
4748
app:layout_constraintTop_toTopOf="parent"
@@ -96,16 +97,16 @@
9697
<View
9798
android:layout_width="match_parent"
9899
android:layout_height="1dp"
99-
android:background="?list_divider_color"/>
100+
android:background="?list_divider_color" />
100101

101102
<LinearLayout
102103
android:id="@+id/spacePreviewButtonBar"
103104
android:layout_width="match_parent"
104105
android:layout_height="wrap_content"
105-
android:gravity="center_horizontal"
106+
android:layout_margin="8dp"
106107
android:elevation="2dp"
107-
android:orientation="horizontal"
108-
android:layout_margin="8dp">
108+
android:gravity="center_horizontal"
109+
android:orientation="horizontal">
109110

110111
<com.google.android.material.button.MaterialButton
111112
android:id="@+id/spacePreviewDeclineInviteButton"

vector/src/main/res/layout/item_space.xml

+2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
android:layout_height="42dp"
1717
android:layout_gravity="center"
1818
android:layout_marginStart="@dimen/layout_horizontal_margin"
19+
android:contentDescription="@string/avatar"
1920
android:duplicateParentState="true"
2021
app:layout_constraintBottom_toTopOf="@+id/groupBottomSeparator"
2122
app:layout_constraintStart_toStartOf="parent"
@@ -44,6 +45,7 @@
4445
android:layout_width="wrap_content"
4546
android:layout_height="wrap_content"
4647
android:layout_marginEnd="21dp"
48+
android:importantForAccessibility="no"
4749
android:src="@drawable/ic_arrow_right"
4850
app:layout_constraintBottom_toTopOf="@+id/groupBottomSeparator"
4951
app:layout_constraintEnd_toEndOf="parent"

0 commit comments

Comments
 (0)