Skip to content

Commit adf8c5f

Browse files
committed
code review
1 parent 43b76f7 commit adf8c5f

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

changelog.d/6233.bugfix

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix | performance regression on roomlist + proper display of space parents in explore rooms.

matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/RoomService.kt

+6-2
Original file line numberDiff line numberDiff line change
@@ -226,8 +226,12 @@ interface RoomService {
226226
): LiveData<PagedList<RoomSummary>>
227227

228228
/**
229-
* TODO Doc.
230-
* @param getFlattenParents When true, the list of known parent and grand parent summaries will be resolved.
229+
* Get's a live paged list from a filter that can be dynamically updated.
230+
*
231+
* @param queryParams The filter to use
232+
* @param pagedListConfig The paged list configuration (page size, initial load, prefetch distance...)
233+
* @param sortOrder defines how to sort the results
234+
* @param getFlattenParents When true, the list of known parents and grand parents summaries will be resolved.
231235
* This can have significant impact on performance, better be used only on manageable list (filtered by displayName, ..).
232236
*/
233237
fun getFilteredPagedRoomSummariesLive(

0 commit comments

Comments
 (0)