You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/pull_request.md
+7-5
Original file line number
Diff line number
Diff line change
@@ -83,15 +83,16 @@ Exceptions can occur:
83
83
84
84
##### PR Review Assignment
85
85
86
-
We use automatic assignment for PR reviews. A PR is automatically routed by GitHub to 2 team members using the round robin algorithm. The process is the following:
86
+
We use automatic assignment for PR reviews. **A PR is automatically routed by GitHub to one team member** using the round robin algorithm. Additional reviewers can be used for complex changes or when the first reviewer is not confident enough on the changes.
87
+
The process is the following:
87
88
88
-
- The PR creator can assign specific people if they have another Android developer in their team or they think a specific reviewer should take a look at the PR.
89
-
-If there are missing reviewers, the PR creator assigns the [element-android-reviewers](https://github.com./orgs/vector-im/teams/element-android-reviewers)team as a reviewer.
90
-
-GitHub automatically assigns other reviewers. If one of the chosen reviewers is not available (holiday, etc.), remove them and set again the team, GitHub will select another reviewer.
89
+
- The PR creator selects the [element-android-reviewers](https://github.com./orgs/vector-im/teams/element-android-reviewers)team as a reviewer.
90
+
-GitHub automatically assign the reviewer. If the reviewer is not available (holiday, etc.), remove them and set again the team, GitHub will select another reviewer.
91
+
-Alternatively, the PR creator can directly assign specific people if they have another Android developer in their team or they think a specific reviewer should take a look at their PR.
91
92
- Reviewers get a notification to make the review: they review the code following the good practice (see the rest of this document).
92
93
- After making their own review, if they feel not confident enough, they can ask another person for a full review, or they can tag someone within a PR comment to check specific lines.
93
94
94
-
For PRs coming from the community, the issue wrangler can assign either the team [element-android-reviewers](https://github.com./orgs/vector-im/teams/element-android-reviewers) or any members directly.
95
+
For PRs coming from the community, the issue wrangler can assign either the team [element-android-reviewers](https://github.com./orgs/vector-im/teams/element-android-reviewers) or any member directly.
95
96
96
97
##### PR review time
97
98
@@ -102,6 +103,7 @@ Some tips to achieve it:
102
103
- Set up your GH notifications correctly
103
104
- Check your pulls page: [https://github.com./pulls](https://github.com./pulls)
104
105
- Check your pending assigned PRs before starting or resuming your day to day tasks
106
+
- If you are busy with high priority tasks, inform the author. They will find another developer
105
107
106
108
It is hard to define a deadline for a review. It depends on the PR size and the complexity. Let's start with a goal of 24h (working day!) for a PR smaller than 500 lines. If bigger, the submitter and the reviewer should discuss.
0 commit comments