Skip to content

Commit 65b634f

Browse files
committed
Update the PR process doc to come back to one reviewer
with optional additional reviewers
1 parent 69920a6 commit 65b634f

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

changelog.d/6396.doc

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Update the PR process doc to come back to one reviewer with optional additional reviewers.

docs/pull_request.md

+7-5
Original file line numberDiff line numberDiff line change
@@ -83,15 +83,16 @@ Exceptions can occur:
8383

8484
##### PR Review Assignment
8585

86-
We use automatic assignment for PR reviews. A PR is automatically routed by GitHub to 2 team members using the round robin algorithm. The process is the following:
86+
We use automatic assignment for PR reviews. **A PR is automatically routed by GitHub to one team member** using the round robin algorithm. Additional reviewers can be used for complex changes or when the first reviewer is not confident enough on the changes.
87+
The process is the following:
8788

88-
- The PR creator can assign specific people if they have another Android developer in their team or they think a specific reviewer should take a look at the PR.
89-
- If there are missing reviewers, the PR creator assigns the [element-android-reviewers](https://github.com./orgs/vector-im/teams/element-android-reviewers) team as a reviewer.
90-
- GitHub automatically assigns other reviewers. If one of the chosen reviewers is not available (holiday, etc.), remove them and set again the team, GitHub will select another reviewer.
89+
- The PR creator selects the [element-android-reviewers](https://github.com./orgs/vector-im/teams/element-android-reviewers) team as a reviewer.
90+
- GitHub automatically assign the reviewer. If the reviewer is not available (holiday, etc.), remove them and set again the team, GitHub will select another reviewer.
91+
- Alternatively, the PR creator can directly assign specific people if they have another Android developer in their team or they think a specific reviewer should take a look at their PR.
9192
- Reviewers get a notification to make the review: they review the code following the good practice (see the rest of this document).
9293
- After making their own review, if they feel not confident enough, they can ask another person for a full review, or they can tag someone within a PR comment to check specific lines.
9394

94-
For PRs coming from the community, the issue wrangler can assign either the team [element-android-reviewers](https://github.com./orgs/vector-im/teams/element-android-reviewers) or any members directly.
95+
For PRs coming from the community, the issue wrangler can assign either the team [element-android-reviewers](https://github.com./orgs/vector-im/teams/element-android-reviewers) or any member directly.
9596

9697
##### PR review time
9798

@@ -102,6 +103,7 @@ Some tips to achieve it:
102103
- Set up your GH notifications correctly
103104
- Check your pulls page: [https://github.com./pulls](https://github.com./pulls)
104105
- Check your pending assigned PRs before starting or resuming your day to day tasks
106+
- If you are busy with high priority tasks, inform the author. They will find another developer
105107

106108
It is hard to define a deadline for a review. It depends on the PR size and the complexity. Let's start with a goal of 24h (working day!) for a PR smaller than 500 lines. If bigger, the submitter and the reviewer should discuss.
107109

0 commit comments

Comments
 (0)