You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/pull_request.md
+6-5
Original file line number
Diff line number
Diff line change
@@ -32,14 +32,15 @@ Also, draft PR should not stay indefinitely in this state. It may be removed if
32
32
33
33
##### PR Review Assignment
34
34
35
-
We use automatic assignment for PR reviews. A PR is automatically routed by GitHub to a team member using the round robin algorithm. The process is the following:
35
+
We use automatic assignment for PR reviews. A PR is automatically routed by GitHub to 2 team members using the round robin algorithm. The process is the following:
36
36
37
-
- The PR creator assigns the [element-android](https://github.com./orgs/vector-im/teams/element-android) team as a reviewer. They can skip this process and assign directly a specific member if they think they should take a look at it.
38
-
- GitHub automatically assigns one reviewer. If the chosen reviewer is not available (holiday, etc.), remove them and set again the team, GitHub will select another reviewer.
39
-
- The reviewer gets a notification to make the review: they review the code following the good practice (see the rest of this document).
37
+
- The PR creator can assign specific people if they have another Android developer in their team or they think a specific reviewer should take a look at the PR.
38
+
- If there are missing reviewers, the PR creator assigns the [element-android-reviewers](https://github.com./orgs/vector-im/teams/element-android-reviewers) team as a reviewer.
39
+
- GitHub automatically assigns other reviewers. If one of the chosen reviewers is not available (holiday, etc.), remove them and set again the team, GitHub will select another reviewer.
40
+
- Reviewers get a notification to make the review: they review the code following the good practice (see the rest of this document).
40
41
- After making their own review, if they feel not confident enough, they can ask another person for a full review, or they can tag someone within a PR comment to check specific lines.
41
42
42
-
For PRs coming from the community, the issue wrangler can assign either the team [element-android](https://github.com./orgs/vector-im/teams/element-android) or any member directly.
43
+
For PRs coming from the community, the issue wrangler can assign either the team [element-android-reviewers](https://github.com./orgs/vector-im/teams/element-android-reviewers) or any members directly.
0 commit comments