Skip to content

Size JVM pools based on node.processors #91543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henningandersen opened this issue Nov 14, 2022 · 4 comments
Closed

Size JVM pools based on node.processors #91543

henningandersen opened this issue Nov 14, 2022 · 4 comments
Labels
:Core/Infra/Settings Settings infrastructure and APIs :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >enhancement Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team team-discuss

Comments

@henningandersen
Copy link
Contributor

Description

In #89662 we changed the node.processors setting to be a double, enabling precise representation of the environment (often docker container) that ES is running in.

However, we still require configuration of the JVM thread pools, preferably through -XX:ActiveProcessorCount. In order to simplify it would be good to instead derive this from the node.processors setting such that the only setting we need about the environment is that setting. This is slightly complicated because it is in the startup process, but seems doable to parse out the setting from the yaml.

Relates #65905 and #89662

@henningandersen henningandersen added >enhancement :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts needs:triage Requires assignment of a team area label labels Nov 14, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Delivery Meta label for Delivery team label Nov 14, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Nov 14, 2022
@mark-vieira mark-vieira added the :Core/Infra/Settings Settings infrastructure and APIs label Nov 14, 2022
@mark-vieira
Copy link
Contributor

This is slightly complicated because it is in the startup process, but seems doable to parse out the setting from the yaml.

The complex bit is that you can pass settings via multiple ways, not just elasticsearch.yaml. Right now our auto-heap is somewhat naive and assumes that node roles will only exist in the YAML config and not via environment variables, CLI args, etc.

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Nov 14, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst
Copy link
Member

rjernst commented May 16, 2024

This was addressed with #101846

@rjernst rjernst closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Settings Settings infrastructure and APIs :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >enhancement Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team team-discuss
Projects
None yet
Development

No branches or pull requests

5 participants