Skip to content

Commit 3e5a16c

Browse files
committed
Include log4j transform jar in docker build context tasks (#69808)
Ensure that the log4j transform jar is included in the generated Docker build context. Also makes some small fixes to the Iron Bank Dockerfile.
1 parent 68ff7ca commit 3e5a16c

File tree

5 files changed

+47
-5
lines changed

5 files changed

+47
-5
lines changed

distribution/docker/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ void addCopyDockerContextTask(Architecture architecture, boolean oss, DockerBase
187187

188188
with dockerBuildContext(architecture, oss, base, true)
189189

190-
into(base == DockerBase.IRON_BANK ? 'scripts' : 'bin') {
190+
into('bin') {
191191
from configurations.transformLog4jJar
192192
}
193193

distribution/docker/docker-build-context/build.gradle

+12
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,25 @@ import org.elasticsearch.gradle.DockerBase
22

33
apply plugin: 'base'
44

5+
configurations {
6+
transformLog4jJar
7+
}
8+
9+
dependencies {
10+
transformLog4jJar project(path: ":distribution:docker:transform-log4j-config", configuration: 'default')
11+
}
12+
513
tasks.register("buildDockerBuildContext", Tar) {
614
archiveExtension = 'tar.gz'
715
compression = Compression.GZIP
816
archiveClassifier = "docker-build-context"
917
archiveBaseName = "elasticsearch"
1018
// Non-local builds don't need to specify an architecture.
1119
with dockerBuildContext(null, false, DockerBase.CENTOS, false)
20+
21+
into('bin') {
22+
from configurations.transformLog4jJar
23+
}
1224
}
1325

1426
tasks.named("assemble").configure {dependsOn "buildDockerBuildContext"}

distribution/docker/ironbank-docker-build-context/build.gradle

+14-2
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,24 @@ import org.elasticsearch.gradle.DockerBase
33

44
apply plugin: 'base'
55

6+
configurations {
7+
transformLog4jJar
8+
}
9+
10+
dependencies {
11+
transformLog4jJar project(path: ":distribution:docker:transform-log4j-config", configuration: 'default')
12+
}
13+
614
tasks.register("buildIronBankDockerBuildContext", Tar) {
715
archiveExtension = 'tar.gz'
816
compression = Compression.GZIP
917
archiveClassifier = "docker-build-context"
1018
archiveBaseName = "elasticsearch-ironbank"
11-
// We always treat Iron Bank builds as local, because that is how they
12-
// are built
19+
// We supply an architecture here because we always treat Iron Bank
20+
// builds as local - because that is how they are built.
1321
with dockerBuildContext(Architecture.X64, false, DockerBase.IRON_BANK, true)
22+
23+
into('scripts') {
24+
from configurations.transformLog4jJar
25+
}
1426
}

distribution/docker/src/docker/Dockerfile

+6-2
Original file line numberDiff line numberDiff line change
@@ -181,9 +181,13 @@ LABEL name="Elasticsearch" \\
181181
release="1" \\
182182
summary="Elasticsearch" \\
183183
description="You know, for search."
184+
<% } %>
184185

185-
RUN mkdir /licenses && \\
186-
cp LICENSE.txt /licenses/LICENSE
186+
<% if (docker_base == 'ubi') { %>
187+
RUN mkdir /licenses && cp LICENSE.txt /licenses/LICENSE
188+
<% } else if (docker_base == 'iron_bank') { %>
189+
RUN mkdir /licenses && cp LICENSE.txt /licenses/LICENSE
190+
COPY LICENSE /licenses/LICENSE.addendum
187191
<% } %>
188192

189193
ENTRYPOINT ["/bin/tini", "--", "/usr/local/bin/docker-entrypoint.sh"]

distribution/docker/ubi-docker-build-context/build.gradle

+14
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,26 @@ import org.elasticsearch.gradle.DockerBase
22

33
apply plugin: 'base'
44

5+
configurations {
6+
transformLog4jJar
7+
}
8+
9+
dependencies {
10+
transformLog4jJar project(path: ":distribution:docker:transform-log4j-config", configuration: 'default')
11+
}
12+
13+
514
tasks.register("buildUbiDockerBuildContext", Tar) {
615
archiveExtension = 'tar.gz'
716
compression = Compression.GZIP
817
archiveClassifier = "docker-build-context"
918
archiveBaseName = "elasticsearch-ubi8"
19+
// Non-local builds don't need to specify an architecture.
1020
with dockerBuildContext(null, false, DockerBase.UBI, false)
21+
22+
into('bin') {
23+
from configurations.transformLog4jJar
24+
}
1125
}
1226

1327
tasks.named("assemble").configure { dependsOn("buildUbiDockerBuildContext") }

0 commit comments

Comments
 (0)