Fix StrictHash contract for extra keys (#254)

* Fix StrictHash contract for extra keys

`Contracts::StrictHash` didn't complain about extra entries in a given
hash. This was because of the missing assertion for keys. Specs hadn't
caught this case because `age` key had a wrong type anyway.

Compare keys for contract and a given hash and return false if they are
equal.

* Do not use a second lookup for the contract in StrictHash assertion

`all?` iterator already provides contract for the `valid?` check. Use
it instead of accessing `contract_hash` again.

Author: smt116

lib/contracts/builtin_contracts.rb

@@ -405,9 +405,10 @@ def initialize(contract_hash)
 
       def valid?(arg)
         return false unless arg.is_a?(Hash)
+        return false unless arg.keys.sort.eql?(contract_hash.keys.sort)
 
-        contract_hash.all? do |key, _v|
-          contract_hash.key?(key) && Contract.valid?(arg[key], contract_hash[key])
+        contract_hash.all? do |key, contract|
+          contract_hash.key?(key) && Contract.valid?(arg[key], contract)
         end
       end
     end

spec/builtin_contracts_spec.rb

@@ -448,7 +448,7 @@ def something(hash)
 
     context "when given an input with extra keys" do
       it "raises an error" do
-        fails { @o.strict_person(:name => "calvin", :age => "10", :soft => true) }
+        fails { @o.strict_person(:name => "calvin", :age => 10, :soft => true) }
       end
     end