Skip to content

CppUnitTestFramework is being included in linux .NET SDK #26590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eerhardt opened this issue Jul 14, 2022 · 6 comments · Fixed by microsoft/vstest#4019
Closed

CppUnitTestFramework is being included in linux .NET SDK #26590

eerhardt opened this issue Jul 14, 2022 · 6 comments · Fixed by microsoft/vstest#4019
Labels
Area-dotnet test untriaged Request triage from a team member

Comments

@eerhardt
Copy link
Member

Describe the bug

The Linux .NET SDK is including a bunch of native Windows .dll files:

image

These assemblies all have the Product Name of Microsoft Windows Operating System, which is a weird product name for assemblies we are installing onto Linux machines.

I'm also not sure what the license is for these assemblies. I'm not sure if they meet the MIT License that we ship the linux .NET SDK under.

To Reproduce

Download and extract the latest .NET linux-x64 SDK. Look at the files being included. It shouldn't contain native assemblies that are compiled for Windows.

cc @dsplaisted @marcpopMSFT @richlander

Further technical details

I'm not sure if or how this affects source-build. These assemblies don't show where they are built from, so I don't know if we are building these assemblies during source-build or not. cc @MichaelSimons

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Jul 14, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@crummel
Copy link
Contributor

crummel commented Jul 14, 2022

Source-build doesn't currently ship 6.0.3xx but this would definitely be a problem if we do so in the future. Poisoning should catch this problem after we start building 6.0.3xx but it's good to know in advance.

@eerhardt
Copy link
Member Author

I looked back and these assemblies weren't present in 6.0.100 but are in 6.0.300, and are in main/7.0.

@richlander
Copy link
Member

It seems like we should enable source-build for newer SDK versions even if we no-one is consuming them. These dependencies look bad. We need a way to avoid that. Sourcebuild seems like our best tool for that.

it's good to know in advance

It'd say it is necessary. This is a P1 problem, not P3.

@MichaelSimons -- can you get this on the schedule for .NET Tactics?

@MichaelSimons
Copy link
Member

These aren't built/included in source-build therefore it wouldn't catch these today. The unified build project feels like it would have the potential to help surface these types of issues where source-build is the only open build.

@marcpopMSFT
Copy link
Member

@pavelhorak @nohwnd as these come from the vstest repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-dotnet test untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants