Skip to content

Drop Support for Python 3.6 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #14
samineer opened this issue Sep 28, 2023 · 2 comments
Closed
Tracked by #14

Drop Support for Python 3.6 #22

samineer opened this issue Sep 28, 2023 · 2 comments

Comments

@samineer
Copy link
Contributor

samineer commented Sep 28, 2023

Reasons

  1. django-ftl doesn't support Python 3.6.
  2. Since 2021-12-23 Python 3.6 is EOL (see PEP 494).
  3. Type annotation improvements in Python 3.7 (see PEP 563).

Possibly changes

  • Use dataclasses instead of attrs.
  • Use builtin dict instead of collections.OrderedDict.

See also What’s New In Python 3.7.

@spookylukey
Copy link
Contributor

If possible, I'd rather not drop Python 3.6 yet - for one thing, because fluent.runtime still supports it, and I'd like fluent-compiler to be a drop in replacement. For the level of type annotations required for #14 (i.e. user facing type annotations, rather than internals), I don't think we'll need much that is only available in Python 3.7. Is there something that can't be typed easily in Python 3.6 that we need, and is available in 3.7?

@samineer
Copy link
Contributor Author

samineer commented Oct 2, 2023

Is there something that can't be typed easily in Python 3.6 that we need, and is available in 3.7?

No, there's nothing. In Python 3.7 added the optional feature that type annotations are not executed at runtime, which improves performance.

I agree with you! So I'm closing this issue.

@samineer samineer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants