[test] don't ignore possible timeout

Instead ASSERT that no timeout occurred and that the window has been
shown.

Then re-enable treating warnings as errors because this actually got
caught by a warning. This fixes #192

Author: muggenhor

CHANGELOG.md

@@ -16,7 +16,7 @@ Please see [CONTRIBUTING.md](https://github.com./cucumber/cucumber/blob/master/CO
 
 ### Fixed
 
-* Remove -werror compiler flag to fix failing build with clang ([#184](https://github.com./cucumber/cucumber-cpp/pull/184) Kamil Strzempowicz)
+* Fix compiler warning ([#192](https://github.com./cucumber/cucumber-cpp/issues/192) [Giel van Schijndel](https://github.com./muggenhor)), ([#184](https://github.com./cucumber/cucumber-cpp/pull/184) [Kamil Strzempowicz](https://github.com./konserw))
 * Add missing virtual destructor in base class SocketServer used by TCPSocketServer and UnixSocketServer ([#183](https://github.com./cucumber/cucumber-cpp/pull/183) Matthieu Longo)
 * Fix breaking changes in API of boost-1.66.0 ([#180](https://github.com./cucumber/cucumber-cpp/pull/180)  Matthieu Longo)
 * Fix conflicting "using std" declaration with "using boost::thread" ([#181](https://github.com./cucumber/cucumber-cpp/pull/181)  Matthieu Longo)

CMakeLists.txt

@@ -27,7 +27,7 @@ set(CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/cmake/modules)
 #
 
 if(CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS_INIT} -Wall -Wextra ${CMAKE_CXX_FLAGS}")
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS_INIT} -Werror -Wall -Wextra ${CMAKE_CXX_FLAGS}")
     # TODO: A better fix should handle ld's --as-needed flag
     if(UNIX AND NOT APPLE)
         set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Xlinker '--no-as-needed'")

examples/CalcQt/features/step_definitions/BoostCalculatorQtSteps.cpp

@@ -1,4 +1,5 @@
 #include <boost/test/unit_test.hpp>
 // Pretend to be GTest
 #define EXPECT_EQ BOOST_CHECK_EQUAL
+#define ASSERT_TRUE BOOST_REQUIRE
 #include "CalculatorQtSteps.cpp"

examples/CalcQt/features/step_definitions/CalculatorQtSteps.cpp

@@ -37,10 +37,11 @@ GIVEN("^I just turned on the calculator$") {
     ctx->calculator.move(0, 0);
     ctx->calculator.show();
 #if QT_VERSION >= 0x050000
-    QTest::qWaitForWindowExposed(&ctx->calculator);
+    const bool window_shown = QTest::qWaitForWindowExposed(&ctx->calculator);
 #else
-    QTest::qWaitForWindowShown(&ctx->calculator);
+    const bool window_shown = QTest::qWaitForWindowShown(&ctx->calculator);
 #endif
+    ASSERT_TRUE(window_shown);
     QTest::qWait(millisecondsToWait());
 }
 

examples/CalcQt/features/step_definitions/QtTestCalculatorQtSteps.cpp

@@ -1,4 +1,5 @@
 #include <QTest>
 // Pretend to be GTest
 #define EXPECT_EQ QCOMPARE
+#define ASSERT_TRUE QVERIFY
 #include "CalculatorQtSteps.cpp"