[vs2017] warning C4265: class has virtual functions, but destructor is not virtual

Author: Matthieu Longo

include/cucumber-cpp/internal/hook/HookRegistrar.hpp

@@ -22,6 +22,11 @@ class CUCUMBER_CPP_EXPORT CallableStep {
 
 class CUCUMBER_CPP_EXPORT Hook {
 public:
+    // [Visual Studio] silence false positive "warning C4265: class has virtual
+    // functions, but destructor is not virtual" requiring virtual destructors
+    // for every class that has virtual functions.
+    virtual ~Hook() {}
+
     void setTags(const std::string &csvTagNotation);
     virtual void invokeHook(Scenario *scenario, CallableStep *step);
     virtual void skipHook();

include/cucumber-cpp/internal/step/StepManager.hpp

@@ -102,6 +102,12 @@ class CUCUMBER_CPP_EXPORT InvokeResult {
 class CUCUMBER_CPP_EXPORT StepInfo : public boost::enable_shared_from_this<StepInfo> {
 public:
     StepInfo(const std::string &stepMatcher, const std::string source);
+
+    // [Visual Studio] silence false positive "warning C4265: class has virtual
+    // functions, but destructor is not virtual" requiring virtual destructors
+    // for every class that has virtual functions.
+    virtual ~StepInfo() {}
+
     SingleStepMatch matches(const std::string &stepDescription) const;
     virtual InvokeResult invokeStep(const InvokeArgs * pArgs) const = 0;
 
@@ -115,6 +121,11 @@ class CUCUMBER_CPP_EXPORT StepInfo : public boost::enable_shared_from_this<StepI
 
 class CUCUMBER_CPP_EXPORT BasicStep {
 public:
+    // [Visual Studio] silence false positive "warning C4265: class has virtual
+    // functions, but destructor is not virtual" requiring virtual destructors
+    // for every class that has virtual functions.
+    virtual ~BasicStep() {}
+
     InvokeResult invoke(const InvokeArgs *pArgs);
 
 protected: