fix lint errors

Author: KSDaemon

packages/cubejs-mssql-driver/package.json

@@ -21,8 +21,8 @@
     "build": "rm -rf dist && npm run tsc",
     "tsc": "tsc",
     "watch": "tsc -w",
-    "lint": "eslint src/* test/* --ext .ts,.js",
-    "lint:fix": "eslint --fix src/* test/* --ext .ts,.js"
+    "lint": "eslint src/* --ext .ts,.js",
+    "lint:fix": "eslint --fix src/* --ext .ts,.js"
   },
   "dependencies": {
     "@cubejs-backend/base-driver": "1.3.5",

packages/cubejs-mssql-driver/src/MSSqlDriver.ts

@@ -35,13 +35,13 @@ const numericTypes = [
 ];
 
 for (const type of numericTypes) {
-  sql.valueHandler.set(type, (value) => value != null ? String(value) : value);
+  sql.valueHandler.set(type, (value) => (value != null ? String(value) : value));
 }
 
 export type MSSqlDriverConfiguration = Omit<MsSQLConfig, 'server'> & {
   readOnly?: boolean;
   server?: string;
-}
+};
 
 const GenericTypeToMSSql: Record<string, string> = {
   boolean: 'bit',
@@ -55,28 +55,29 @@ const MSSqlToGenericType: Record<string, string> = {
   bit: 'boolean',
   uniqueidentifier: 'uuid',
   datetime2: 'timestamp'
-}
+};
 
 /**
  * MS SQL driver class.
  */
 export class MSSqlDriver extends BaseDriver implements DriverInterface {
-
   private readonly connectionPool: ConnectionPool;
+
   private readonly initialConnectPromise: Promise<ConnectionPool>;
+
   private readonly config: MSSqlDriverConfiguration;
 
   /**
    * Returns default concurrency value.
    */
-  static getDefaultConcurrency() {
+  public static getDefaultConcurrency() {
     return 2;
   }
 
   /**
    * Class constructor.
    */
-  constructor(config: MSSqlDriverConfiguration & {
+  public constructor(config: MSSqlDriverConfiguration & {
       /**
        * Data source name.
        */
@@ -93,8 +94,7 @@ export class MSSqlDriver extends BaseDriver implements DriverInterface {
        */
       testConnectionTimeout?: number,
       server?: string,
-    } = {}
-  ) {
+    } = {}) {
     super({
       testConnectionTimeout: config.testConnectionTimeout,
     });
@@ -140,7 +140,7 @@ export class MSSqlDriver extends BaseDriver implements DriverInterface {
    * Note: It returns the unprefixed option names.
    * In case of using multi sources options need to be prefixed manually.
    */
-  static driverEnvVariables() {
+  public static driverEnvVariables() {
     return [
       'CUBEJS_DB_HOST',
       'CUBEJS_DB_NAME',
@@ -184,7 +184,7 @@ export class MSSqlDriver extends BaseDriver implements DriverInterface {
       });
       stream.on('error', (err: Error) => {
         reject(err);
-      })
+      });
     });
     return {
       rowStream: stream,
@@ -211,7 +211,7 @@ export class MSSqlDriver extends BaseDriver implements DriverInterface {
    *   }
    * }} fields
    */
-  mapFields(fields: Record<string, any>) {
+  private mapFields(fields: Record<string, any>) {
     return Object.keys(fields).map((field) => {
       let type;
       switch (fields[field].type) {
@@ -368,7 +368,7 @@ export class MSSqlDriver extends BaseDriver implements DriverInterface {
     return GenericTypeToMSSql[columnType] || super.fromGenericType(columnType);
   }
 
-  protected toGenericType(columnType: string): string{
+  protected toGenericType(columnType: string): string {
     return MSSqlToGenericType[columnType] || super.toGenericType(columnType);
   }
 

packages/cubejs-mssql-driver/src/QueryStream.ts

@@ -9,12 +9,13 @@ import {
  */
 export class QueryStream extends Readable {
   private request: sql.Request | null;
+
   private toRead: number = 0;
 
   /**
    * @constructor
    */
-  constructor(request: sql.Request, highWaterMark: number) {
+  public constructor(request: sql.Request, highWaterMark: number) {
     super({
       objectMode: true,
       highWaterMark:
@@ -27,10 +28,10 @@ export class QueryStream extends Readable {
       if (this.toRead-- <= 0 || !canAdd) {
         this.request?.pause();
       }
-    })
+    });
     this.request.on('done', () => {
       this.push(null);
-    })
+    });
     this.request.on('error', (err: Error) => {
       this.destroy(err);
     });
@@ -39,23 +40,23 @@ export class QueryStream extends Readable {
   /**
    * @override
    */
-  _read(toRead: number) {
+  public _read(toRead: number) {
     this.toRead += toRead;
     this.request?.resume();
   }
 
-  transformRow(row: Record<string, any>) {
-    for (const key in row) {
-      if (row.hasOwnProperty(key) && row[key] && row[key] instanceof Date) {
-        row[key] = row[key].toJSON();
+  private transformRow(row: Record<string, any>) {
+    for (const [key, value] of Object.entries(row)) {
+      if (value instanceof Date) {
+        row[key] = value.toJSON();
       }
     }
   }
 
   /**
    * @override
    */
-  _destroy(error: any, callback: CallableFunction) {
+  public _destroy(error: any, callback: CallableFunction) {
     this.request?.cancel();
     this.request = null;
     callback(error);