fix(ecmp_vip.go): non-local service advertisement

With advertiseService set to false by default, it means that it won't
ever get re-evaluated if the service isn't a local host and will ALWAYS
result in withdrawing the VIPs which is incorrect. It needs to default
to true, and only override the boolean if serviceLocal is set to true.

Author: aauren

pkg/controllers/routing/ecmp_vip.go

@@ -366,7 +366,7 @@ func (nrc *NetworkRoutingController) getLoadBalancerIPs(svc *v1core.Service) []s
 
 func (nrc *NetworkRoutingController) getChangedVIPs(oldSvc, newSvc *v1core.Service,
 	onlyActiveEndpoints bool) ([]string, []string, error) {
-	advertiseService := false
+	advertiseService := true
 
 	_, hasLocalAnnotation := newSvc.Annotations[svcLocalAnnotation]
 	hasLocalTrafficPolicy := newSvc.Spec.ExternalTrafficPolicy == v1core.ServiceExternalTrafficPolicyTypeLocal