Skip to content

feat: support multiple slots in Bouncer component #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

zAlweNy26
Copy link
Contributor

Hi, I know I didn't make the issue first and I'm sorry for that, but I thought it was easier to show you what I wanted to propose, otherwise you can close the PR if you don't like the idea :)

@Barbapapazes
Copy link
Owner

Hey 👋,

Do you have a more realistic example on how you will use this feature?

@zAlweNy26
Copy link
Contributor Author

Yeah, I thought about this feature because I have a component UDropdown (the one from Nuxt UI) and I want to disable it based on an ability. At the moment I'm using the Bouncer but I had to duplicate the code for the can and cannot slots. I couldn't use the allows or denies methods since they are async and creating a computed for them is also not possible because the component is in a table and the check must be done for each row. Am I missing something or my assumptions are correct?

@zAlweNy26
Copy link
Contributor Author

Hi @Barbapapazes, have you had a chance to think about this?

@Barbapapazes
Copy link
Owner

Hey! Sorry for the delay, I will have a look!

@Barbapapazes Barbapapazes changed the title Support default slot in Bouncer component feat: support multiple slots in Bouncer component Jan 26, 2025
@Barbapapazes Barbapapazes merged commit b866e13 into Barbapapazes:main Jan 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants