Skip to content

Commit 09ade59

Browse files
authored
remove getImmutableFieldChanges references (#147)
fix aws-controllers-k8s/code-generator#565 Description of changes: Remove getImmutableFieldChanges from hooks to support cel immutability By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent d463a67 commit 09ade59

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

pkg/resource/identity_provider_config/hooks.go

-8
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,8 @@ package identity_provider_config
1515

1616
import (
1717
"context"
18-
"fmt"
19-
"strings"
2018

2119
ackcompare "github.com./aws-controllers-k8s/runtime/pkg/compare"
22-
ackerr "github.com./aws-controllers-k8s/runtime/pkg/errors"
2320
ackrtlog "github.com./aws-controllers-k8s/runtime/pkg/runtime/log"
2421
)
2522

@@ -84,10 +81,5 @@ func (rm *resourceManager) customUpdate(
8481
exit := rlog.Trace("rm.customUpdate")
8582
defer exit(err)
8683

87-
if immutableFieldChanges := rm.getImmutableFieldChanges(delta); len(immutableFieldChanges) > 0 {
88-
msg := fmt.Sprintf("Immutable Spec fields have been modified: %s", strings.Join(immutableFieldChanges, ","))
89-
return nil, ackerr.NewTerminalError(fmt.Errorf(msg))
90-
}
91-
9284
return nil, nil
9385
}

pkg/resource/nodegroup/hook.go

-6
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import (
1818
"fmt"
1919
"reflect"
2020
"strconv"
21-
"strings"
2221
"time"
2322

2423
ackcompare "github.com./aws-controllers-k8s/runtime/pkg/compare"
@@ -258,11 +257,6 @@ func (rm *resourceManager) customUpdate(
258257
exit := rlog.Trace("rm.customUpdate")
259258
defer exit(err)
260259

261-
if immutableFieldChanges := rm.getImmutableFieldChanges(delta); len(immutableFieldChanges) > 0 {
262-
msg := fmt.Sprintf("Immutable Spec fields have been modified: %s", strings.Join(immutableFieldChanges, ","))
263-
return nil, ackerr.NewTerminalError(fmt.Errorf(msg))
264-
}
265-
266260
if delta.DifferentAt("Spec.Tags") {
267261
err := tags.SyncTags(
268262
ctx, rm.sdkapi, rm.metrics,

0 commit comments

Comments
 (0)