Skip to content

Add or Remove Line Numbers Error following V0.7.5 Update #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theGoldenLink opened this issue Sep 20, 2022 · 7 comments
Closed

Add or Remove Line Numbers Error following V0.7.5 Update #47

theGoldenLink opened this issue Sep 20, 2022 · 7 comments
Assignees
Labels
archived Archived and locked issues bug Something isn't working commands Extension Commands issues or changes good-first-issue Good for newcomers need-more-info Need More Information

Comments

@theGoldenLink
Copy link

Commands
G-Code: G-Code: Remove Line Numbers
G-Code: G-Code Add Line Numbers
These commands result in errors and will not add or remove line numbers.

Steps to reproduce the behavior:
With a g-code file open, (whether .txt, .nc)

  1. Go to 'Command Palette.'
  2. Click on 'G-Code: G-Code Add Line Numbers'
  3. Error is made known by a pop-up presenting you with a phrase letting the user know the command did not work.

When the command is selected it should either remove or add line numbers.

  • OS Version: Windows_NT x64 10.0.22000
  • VSCode Version:1.71.2
  • Extension Version: V0.7.5

On older Extension Version: V0.7.4 both commands work as expected.

@github-actions
Copy link

Hello and welcome! Thanks for creating your first issue! Someone from our community will get back to you soon!

@mikecentola mikecentola self-assigned this Sep 21, 2022
@mikecentola mikecentola added bug Something isn't working good-first-issue Good for newcomers commands Extension Commands issues or changes need-more-info Need More Information labels Sep 21, 2022
@mikecentola
Copy link
Member

@theGoldenLink Can you let me know which settings you have enabled/disabled for the line numberer in configuration?

@theGoldenLink
Copy link
Author

theGoldenLink commented Sep 21, 2022

@mikecentola
Gcode > Line Numberer: Add Space After -- Enabled
Gcode > Line Numberer: Frequency -- Every Line (Default)
Gcode > Line Numberer: Ignore Blank -- Enabled
Gcode > Line Numberer: Ignore Comments -- Enabled
Gcode > Line Numberer: Ignore Program Numberer -- Enabled

@mikecentola
Copy link
Member

@theGoldenLink thanks. looking into it right now

@mikecentola
Copy link
Member

Ended up refactoring the entire line numberer with a bunch of new options and features as well. Tying up some loose ends with it right now and testing it out.

@mikecentola
Copy link
Member

Well it turns out that, it wasn't my line Numberer code at all. It's something to do with the way webpack bundles in production vs development. I couldn't reproduce the error on my machine when debugging, but when I opened another window with v0.7.5 installed, I could reproduce. At least the whole line numberer system is much better now and more suited to large files.

@mikecentola mikecentola mentioned this issue Sep 23, 2022
7 tasks
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.

@github-actions github-actions bot added the archived Archived and locked issues label Nov 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived and locked issues bug Something isn't working commands Extension Commands issues or changes good-first-issue Good for newcomers need-more-info Need More Information
Projects
None yet
Development

No branches or pull requests

2 participants