-
-
Notifications
You must be signed in to change notification settings - Fork 28
Add or Remove Line Numbers Error following V0.7.5 Update #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello and welcome! Thanks for creating your first issue! Someone from our community will get back to you soon! |
@theGoldenLink Can you let me know which settings you have enabled/disabled for the line numberer in configuration? |
@mikecentola |
@theGoldenLink thanks. looking into it right now |
Ended up refactoring the entire line numberer with a bunch of new options and features as well. Tying up some loose ends with it right now and testing it out. |
Well it turns out that, it wasn't my line Numberer code at all. It's something to do with the way webpack bundles in production vs development. I couldn't reproduce the error on my machine when debugging, but when I opened another window with v0.7.5 installed, I could reproduce. At least the whole line numberer system is much better now and more suited to large files. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics. |
Commands
G-Code: G-Code: Remove Line Numbers
G-Code: G-Code Add Line Numbers
These commands result in errors and will not add or remove line numbers.
Steps to reproduce the behavior:
With a g-code file open, (whether .txt, .nc)
When the command is selected it should either remove or add line numbers.
On older Extension Version: V0.7.4 both commands work as expected.
The text was updated successfully, but these errors were encountered: