Internal wrapper for direct eager dispatching. #23777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgogul
approved these changes
Apr 3, 2019
| internal func makeTensor(owning pointer: CTensorHandle) -> AnyTensor { | ||
| switch (_cDataType) { | ||
| case TF_BOOL: | ||
| return Tensor<Bool>.init(handle: TensorHandle(_owning: pointer)) |
|
@swift-ci please test tensorflow |
|
Just a friendly reminder that addition or changes to public APIs without underscore prefixes should go through reviews by API owners. It’s mainly about the newly added public protocol AnyTensor. |
rxwei
reviewed
Apr 4, 2019
|
@swift-ci please test tensorflow |
3 similar comments
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
rxwei
reviewed
Apr 4, 2019
|
@swift-ci please test tensorflow |
rxwei
reviewed
Apr 6, 2019
- Add support for dispatching an eager op which returns a tensor group. - AnyTensor type for array output and input lists. - Add proper eager support for saveV2 and restoreV2 ops. These will be used for model checkpointing.
|
@swift-ci please test tensorflow |
|
@swift-ci please test macos |
|
@swift-ci please test tensorflow macos |
|
@swift-ci please test gpu macos |
|
@swift-ci please test gpu tensorflow |
|
@swift-ci please test tensorflow gpu |
|
Build failed |
|
@swift-ci please test tensorflow macos |
|
@swift-ci please test tensorflow gpu |
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
May 11, 2019
- Add support for dispatching an eager op which returns a tensor group. - AnyTensor type for array output and input lists. - Add proper eager support for saveV2 and restoreV2 ops. These will be used for model checkpointing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be used for model checkpointing.