[Compose] Fix margin for Chain first and last elements

oscar-ad · oscar-ad · commit 3fcc3608c9a5 · 2022-04-21T14:03:40.000-07:00
Fixes #572 The margin for constraints that can be declared for chains would not be applied for VerticalChains. Also applies the gone margin, which was ignored for both kinds of Chains.
diff --git a/constraintlayout/core/src/main/java/androidx/constraintlayout/core/state/ConstraintReference.java b/constraintlayout/core/src/main/java/androidx/constraintlayout/core/state/ConstraintReference.java
@@ -76,15 +76,16 @@ public interface ConstraintReferenceFactory {
     protected int mMarginRight = 0;
     protected int mMarginStart = 0;
     protected int mMarginEnd = 0;
-    int mMarginTop = 0;
-    int mMarginBottom = 0;
-
-    int mMarginLeftGone = 0;
-    int mMarginRightGone = 0;
-    int mMarginStartGone = 0;
-    int mMarginEndGone = 0;
-    int mMarginTopGone = 0;
-    int mMarginBottomGone = 0;
+    protected int mMarginTop = 0;
+    protected int mMarginBottom = 0;
+
+    protected int mMarginLeftGone = 0;
+    protected int mMarginRightGone = 0;
+    protected int mMarginStartGone = 0;
+    protected int mMarginEndGone = 0;
+    protected int mMarginTopGone = 0;
+    protected int mMarginBottomGone = 0;
+
     int mMarginBaseline = 0;
     int mMarginBaselineGone = 0;
 
diff --git a/constraintlayout/core/src/main/java/androidx/constraintlayout/core/state/helpers/ChainReference.java b/constraintlayout/core/src/main/java/androidx/constraintlayout/core/state/helpers/ChainReference.java
@@ -16,6 +16,7 @@
 
 package androidx.constraintlayout.core.state.helpers;
 
+import androidx.constraintlayout.core.state.ConstraintReference;
 import androidx.constraintlayout.core.state.HelperReference;
 import androidx.constraintlayout.core.state.State;
 
@@ -54,5 +55,4 @@ public ChainReference bias(float bias) {
         mBias = bias;
         return this;
     }
-
 }
diff --git a/constraintlayout/core/src/main/java/androidx/constraintlayout/core/state/helpers/HorizontalChainReference.java b/constraintlayout/core/src/main/java/androidx/constraintlayout/core/state/helpers/HorizontalChainReference.java
@@ -42,16 +42,19 @@ public void apply() {
             if (first == null) {
                 first = reference;
                 if (mStartToStart != null) {
-                    first.startToStart(mStartToStart).margin(mMarginStart);
+                    first.startToStart(mStartToStart)
+                            .margin(mMarginStart)
+                            .marginGone(mMarginStartGone);
                 } else if (mStartToEnd != null) {
-                    first.startToEnd(mStartToEnd).margin(mMarginStart);
+                    first.startToEnd(mStartToEnd).margin(mMarginStart).marginGone(mMarginStartGone);
                 } else if (mLeftToLeft != null) {
                     // TODO: Hack until we support RTL properly
-                    first.startToStart(mLeftToLeft).margin(mMarginLeft);
+                    first.startToStart(mLeftToLeft).margin(mMarginLeft).marginGone(mMarginLeftGone);
                 } else if (mLeftToRight != null) {
                     // TODO: Hack until we support RTL properly
-                    first.startToEnd(mLeftToRight).margin(mMarginLeft);
+                    first.startToEnd(mLeftToRight).margin(mMarginLeft).marginGone(mMarginLeftGone);
                 } else {
+                    // No constraint declared, default to Parent.
                     first.startToStart(State.PARENT);
                 }
             }
@@ -64,16 +67,17 @@ public void apply() {
 
         if (previous != null) {
             if (mEndToStart != null) {
-                previous.endToStart(mEndToStart).margin(mMarginEnd);
+                previous.endToStart(mEndToStart).margin(mMarginEnd).marginGone(mMarginEndGone);
             } else if (mEndToEnd != null) {
-                previous.endToEnd(mEndToEnd).margin(mMarginEnd);
+                previous.endToEnd(mEndToEnd).margin(mMarginEnd).marginGone(mMarginEndGone);
             } else if (mRightToLeft != null) {
                 // TODO: Hack until we support RTL properly
-                previous.endToStart(mRightToLeft).margin(mMarginRight);
+                previous.endToStart(mRightToLeft).margin(mMarginRight).marginGone(mMarginRightGone);
             } else if (mRightToRight != null) {
                 // TODO: Hack until we support RTL properly
-                previous.endToEnd(mRightToRight).margin(mMarginRight);
+                previous.endToEnd(mRightToRight).margin(mMarginRight).marginGone(mMarginRightGone);
             } else {
+                // No constraint declared, default to Parent.
                 previous.endToEnd(State.PARENT);
             }
         }
diff --git a/constraintlayout/core/src/main/java/androidx/constraintlayout/core/state/helpers/VerticalChainReference.java b/constraintlayout/core/src/main/java/androidx/constraintlayout/core/state/helpers/VerticalChainReference.java
@@ -42,10 +42,11 @@ public void apply() {
             if (first == null) {
                 first = reference;
                 if (mTopToTop != null) {
-                    first.topToTop(mTopToTop);
+                    first.topToTop(mTopToTop).margin(mMarginTop).marginGone(mMarginTopGone);
                 } else if (mTopToBottom != null) {
-                    first.topToBottom(mTopToBottom);
+                    first.topToBottom(mTopToBottom).margin(mMarginTop).marginGone(mMarginTopGone);
                 } else {
+                    // No constraint declared, default to Parent.
                     first.topToTop(State.PARENT);
                 }
             }
@@ -58,10 +59,15 @@ public void apply() {
 
         if (previous != null) {
             if (mBottomToTop != null) {
-                previous.bottomToTop(mBottomToTop);
+                previous.bottomToTop(mBottomToTop)
+                        .margin(mMarginBottom)
+                        .marginGone(mMarginBottomGone);
             } else if (mBottomToBottom != null) {
-                previous.bottomToBottom(mBottomToBottom);
+                previous.bottomToBottom(mBottomToBottom)
+                        .margin(mMarginBottom)
+                        .marginGone(mMarginBottomGone);
             } else {
+                // No constraint declared, default to Parent.
                 previous.bottomToBottom(State.PARENT);
             }
         }
@@ -86,5 +92,4 @@ public void apply() {
             }
         }
     }
-
 }
diff --git a/projects/ComposeConstraintLayout/app/src/main/java/com/example/constraintlayout/verification/dsl/Chains.kt b/projects/ComposeConstraintLayout/app/src/main/java/com/example/constraintlayout/verification/dsl/Chains.kt
@@ -35,6 +35,7 @@ import androidx.constraintlayout.compose.ChainStyle
 import androidx.constraintlayout.compose.ConstraintLayout
 import androidx.constraintlayout.compose.ConstraintSet
 import androidx.constraintlayout.compose.Dimension
+import androidx.constraintlayout.compose.Visibility
 
 @Preview
 @Composable
@@ -114,7 +115,42 @@ fun Test12() { // Constraint an horizontal chain
             start.linkTo(parent.start, 12.dp)
         }
         constrain(chain1) {
-            start.linkTo(box3.end)
+            start.linkTo(box3.end, 10.dp)
+        }
+    }
+    ThreeBoxChainLayout(constraintSet = constraintSet)
+}
+
+@Preview
+@Composable
+fun Test18() { // Constraint an horizontal chain with gone margins
+    val constraintSet = ConstraintSet {
+        val box1 = createRefFor("box1")
+        val box2 = createRefFor("box2")
+        val box3 = createRefFor("box3")
+        val chain1 = createHorizontalChain(box1, box2, chainStyle = ChainStyle.Spread)
+
+        constrain(box1) {
+            width = Dimension.value(20.dp)
+            height = Dimension.value(20.dp)
+            centerVerticallyTo(parent)
+        }
+        constrain(box2) {
+            width = Dimension.value(20.dp)
+            height = Dimension.value(20.dp)
+            centerVerticallyTo(box1)
+        }
+        constrain(box3) {
+            width = Dimension.value(200.dp)
+            height = Dimension.value(20.dp)
+            top.linkTo(parent.top, 12.dp)
+            start.linkTo(parent.start, 12.dp)
+            visibility = Visibility.Gone
+        }
+        constrain(chain1) {
+            start.linkTo(box3.end, 10.dp, 100.dp)
+            // gone margin with parent should not matter
+            end.linkTo(parent.end, 10.dp, 200.dp)
         }
     }
     ThreeBoxChainLayout(constraintSet = constraintSet)
@@ -146,7 +182,43 @@ fun Test13() { // Constrain a vertical chain
             start.linkTo(parent.start, 12.dp)
         }
         constrain(chain1) {
-            top.linkTo(box3.bottom)
+            top.linkTo(box3.bottom, 10.dp)
+        }
+    }
+    ThreeBoxChainLayout(constraintSet = constraintSet)
+}
+
+@Preview
+@Composable
+fun Test17() { // Constrain a vertical chain with gone margins
+    val constraintSet = ConstraintSet {
+        val box1 = createRefFor("box1")
+        val box2 = createRefFor("box2")
+        val box3 = createRefFor("box3")
+        val chain1 = createVerticalChain(box1, box2, chainStyle = ChainStyle.Spread)
+
+        constrain(box1) {
+            width = Dimension.value(20.dp)
+            height = Dimension.value(20.dp)
+            centerHorizontallyTo(parent)
+        }
+        constrain(box2) {
+            width = Dimension.value(20.dp)
+            height = Dimension.value(20.dp)
+            centerHorizontallyTo(box1)
+        }
+        constrain(box3) {
+            width = Dimension.value(20.dp)
+            height = Dimension.value(200.dp)
+            top.linkTo(parent.top, 12.dp)
+            start.linkTo(parent.start, 12.dp)
+            visibility = Visibility.Gone
+        }
+        constrain(chain1) {
+            // With the gone margin it should basically layout the same as if box3 was visible
+            top.linkTo(box3.bottom, 10.dp, 100.dp)
+            // gone margin with parent should not matter
+            bottom.linkTo(parent.bottom, 10.dp, 200.dp)
         }
     }
     ThreeBoxChainLayout(constraintSet = constraintSet)
diff --git a/projects/ComposeConstraintLayout/app/src/main/res/raw/results.txt b/projects/ComposeConstraintLayout/app/src/main/res/raw/results.txt

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`
`17`	`17`	`package androidx.constraintlayout.core.state.helpers;`
`18`	`18`
	`19`	`+import androidx.constraintlayout.core.state.ConstraintReference;`
`19`	`20`	`import androidx.constraintlayout.core.state.HelperReference;`
`20`	`21`	`import androidx.constraintlayout.core.state.State;`
`21`	`22`
`@@ -54,5 +55,4 @@ public ChainReference bias(float bias) {`
`54`	`55`	`mBias = bias;`
`55`	`56`	`return this;`
`56`	`57`	`}`
`57`		`-`
`58`	`58`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,10 +42,11 @@ public void apply() {`
`42`	`42`	`if (first == null) {`
`43`	`43`	`first = reference;`
`44`	`44`	`if (mTopToTop != null) {`
`45`		`- first.topToTop(mTopToTop);`
	`45`	`+ first.topToTop(mTopToTop).margin(mMarginTop).marginGone(mMarginTopGone);`
`46`	`46`	`} else if (mTopToBottom != null) {`
`47`		`- first.topToBottom(mTopToBottom);`
	`47`	`+ first.topToBottom(mTopToBottom).margin(mMarginTop).marginGone(mMarginTopGone);`
`48`	`48`	`} else {`
	`49`	`+ // No constraint declared, default to Parent.`
`49`	`50`	`first.topToTop(State.PARENT);`
`50`	`51`	`}`
`51`	`52`	`}`
`@@ -58,10 +59,15 @@ public void apply() {`
`58`	`59`
`59`	`60`	`if (previous != null) {`
`60`	`61`	`if (mBottomToTop != null) {`
`61`		`- previous.bottomToTop(mBottomToTop);`
	`62`	`+ previous.bottomToTop(mBottomToTop)`
	`63`	`+ .margin(mMarginBottom)`
	`64`	`+ .marginGone(mMarginBottomGone);`
`62`	`65`	`} else if (mBottomToBottom != null) {`
`63`		`- previous.bottomToBottom(mBottomToBottom);`
	`66`	`+ previous.bottomToBottom(mBottomToBottom)`
	`67`	`+ .margin(mMarginBottom)`
	`68`	`+ .marginGone(mMarginBottomGone);`
`64`	`69`	`} else {`
	`70`	`+ // No constraint declared, default to Parent.`
`65`	`71`	`previous.bottomToBottom(State.PARENT);`
`66`	`72`	`}`
`67`	`73`	`}`
`@@ -86,5 +92,4 @@ public void apply() {`
`86`	`92`	`}`
`87`	`93`	`}`
`88`	`94`	`}`
`89`		`-`
`90`	`95`	`}`