Fix UV writing in append mode

Author: trowski

lib/UvHandle.php

@@ -172,10 +172,10 @@ private function push(string $data): Promise
                 }
             } else {
                 StatCache::clear($this->path);
-                $newPosition = $this->position + $length;
-                $delta = $newPosition - $this->position;
-                $this->position = ($this->mode[0] === "a") ? $this->position : $newPosition;
-                $this->size += $delta;
+                $this->position += $length;
+                if ($this->position > $this->size) {
+                    $this->size = $this->position;
+                }
                 $deferred->resolve($length);
             }
         };

test/HandleTest.php

@@ -79,6 +79,23 @@ public function testWriteAfterEnd()
         });
     }
 
+    public function testWriteInAppendMode()
+    {
+        $this->execute(function () {
+            $path = Fixture::path() . "/write";
+            /** @var \Amp\File\Handle $handle */
+            $handle = yield File\open($path, "a+");
+            $this->assertSame(0, $handle->tell());
+            yield $handle->write("bar");
+            yield $handle->write("foo");
+            yield $handle->write("baz");
+            $this->assertSame(9, $handle->tell());
+            yield $handle->seek(0);
+            $this->assertSame(0, $handle->tell());
+            $this->assertSame("barfoobaz", yield $handle->read());
+        });
+    }
+
     public function testReadingToEof()
     {
         $this->execute(function () {