Merge pull request #26 from mmenozzi/mkdir-mode-fix

Fixes wrong mkdir default mode

Author: bwoebi

lib/functions.php

@@ -242,7 +242,7 @@ function unlink(string $path): Promise {
  * @param bool $recursive
  * @return \Amp\Promise<null>
  */
-function mkdir(string $path, int $mode = 0644, bool $recursive = false): Promise {
+function mkdir(string $path, int $mode = 0777, bool $recursive = false): Promise {
     return filesystem()->mkdir($path, $mode, $recursive);
 }
 

test/DriverTest.php

@@ -224,9 +224,11 @@ public function testMkdirRmdir() {
 
             $dir = "{$fixtureDir}/newdir";
 
+            \umask(0022);
+
             yield File\mkdir($dir);
             $stat = yield File\stat($dir);
-            $this->assertSame(0644, $stat["mode"] & 0777);
+            $this->assertSame('0755', $this->getPermissionsFromStat($stat));
             yield File\rmdir($dir);
             $this->assertNull(yield File\stat($dir));
 
@@ -235,7 +237,7 @@ public function testMkdirRmdir() {
 
             yield File\mkdir($dir, 0764, true);
             $stat = yield File\stat($dir);
-            $this->assertSame(0764 & (~\umask()), $stat["mode"] & 0777);
+            $this->assertSame('0744', $this->getPermissionsFromStat($stat));
         });
     }
 
@@ -325,4 +327,12 @@ public function testTouch() {
             $this->assertTrue($newStat["mtime"] > $oldStat["mtime"]);
         });
     }
+
+    /**
+     * @param array $stat
+     * @return string
+     */
+    private function getPermissionsFromStat(array $stat): string {
+        return \substr(\decoct($stat["mode"]), 1);
+    }
 }