Skip to content

Upgrade to sqlalchemy 2 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhauru opened this issue Jun 21, 2023 · 2 comments
Closed

Upgrade to sqlalchemy 2 #104

mhauru opened this issue Jun 21, 2023 · 2 comments

Comments

@mhauru
Copy link
Collaborator

mhauru commented Jun 21, 2023

Upgrading from 1.4 to 2 is currently held back by sqlacodegen not supporting 2. There is a PR, but it hasn't made progress for a while, due to the maintainer having competing priorities: agronholm/sqlacodegen#249

We should do this once we can though. It would enable

  • moving to smartnoise-sql 1.0 (we are on 0.2)
  • using some more developed asyncio stuff in sqlalchemy
  • type hints for sqlalchemy
@Iain-S Iain-S mentioned this issue Jul 19, 2023
Closed
@mhauru
Copy link
Collaborator Author

mhauru commented Aug 4, 2023

The upgrade to SQLAlchemy 2 is in sqlacodegen/main, but there's no release yet with that work included. The maintainer says he'll make one soon. Once that is done, the whole upgrade path to using SQLAlchemy 2 and the latest snsql version opens up for us, see the opening message. I started work on doing this on the branch sqlalchemy2 if anyone wants to get to it while I'm gone.

@mhauru
Copy link
Collaborator Author

mhauru commented Sep 1, 2023

Done

@mhauru mhauru closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhauru