Skip to content

Pseudo C missing the name of the member in structure dereference #6045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bb33bb opened this issue Oct 26, 2024 · 8 comments
Open

Pseudo C missing the name of the member in structure dereference #6045

bb33bb opened this issue Oct 26, 2024 · 8 comments
Labels
Effort: High Issue should take > 1 month Impact: Medium Issue is impactful with a bad, or no, workaround Type: Enhancement Issue is a small enhancement to existing functionality

Comments

@bb33bb
Copy link

bb33bb commented Oct 26, 2024

Version and Platform (required):

Bug Description:
reverse code on vmlinux, we get the following code

ffffff800834dc58    int oom_kill_process(struct oom_control* oc, char const* message)

ffffff800834dc58    {
ffffff800834dc58        int64_t* x18;
ffffff800834dc5c        int64_t x30;
ffffff800834dc5c        *(uint64_t*)x18 = x30;
ffffff800834dc78        int64_t __saved_x29;
ffffff800834dc78        int64_t* x29 = &__saved_x29;
ffffff800834dc84        int0_t sp_el0;
ffffff800834dc84        uint64_t t_1 = _ReadStatusReg(sp_el0);
ffffff800834dc8c        struct oom_control* zonelist = oc;
ffffff800834dc90        int64_t var_68 = 0;
ffffff800834dc94        struct task_struct* chosen = oc->chosen;
ffffff800834dc98        uint64_t mm_1 = (uint64_t)oc->chosen_points;
ffffff800834dca4        struct spinlock* t = &chosen->alloc_lock;
ffffff800834dcb0        *(uint32_t*)(t_1 + 0x48) += 1;
ffffff800834dcb4        __prefetch(t->); ////////////////////  is this right or designed purposed?
@xusheng6
Copy link
Member

Can you show the corresponding HLIL? Chances we have have a bug in the pseudo-C rendering when there is a structure reference to an offset where there is no member

@xusheng6 xusheng6 changed the title Pseudo C not complete? Pseudo C not missing the name of the member in structure dereference Oct 29, 2024
@xusheng6 xusheng6 added the State: Blocked (Customer) Issue is blocked on waiting for a response from a customer label Oct 29, 2024
@bb33bb
Copy link
Author

bb33bb commented Oct 29, 2024

Can you show the corresponding HLIL? Chances we have have a bug in the pseudo-C rendering when there is a structure reference to an offset where there is no member

我先关闭这个,然后找到文件后,下次直接发过来哈。

@bb33bb bb33bb closed this as completed Oct 29, 2024
@xusheng6 xusheng6 changed the title Pseudo C not missing the name of the member in structure dereference Pseudo C missing the name of the member in structure dereference Oct 29, 2024
@xusheng6
Copy link
Member

xusheng6 commented Oct 29, 2024

I am re-opening this issue because it is a valid issue. I have seen it before but I did not create an issue for it. Please take your time to find the file

We do not mind having more issues open, so please do not close them if they are not yet resolved

@xusheng6 xusheng6 reopened this Oct 29, 2024
@bb33bb
Copy link
Author

bb33bb commented Oct 31, 2024

I am re-opening this issue because it is a valid issue. I have seen it before but I did not create an issue for it. Please take your time to find the file

We do not mind having more issues open, so please do not close them if they are not yet resolved

好的,确实之前怕这里添加太多麻烦给您。谢谢!
我把这个文件上传上来。稍等一下午。文件比较大,有效期大概2天,所以请及时下载。

@xusheng6
Copy link
Member

I am re-opening this issue because it is a valid issue. I have seen it before but I did not create an issue for it. Please take your time to find the file
We do not mind having more issues open, so please do not close them if they are not yet resolved

好的,确实之前怕这里添加太多麻烦给您。谢谢! 我把这个文件上传上来。稍等一下午。文件比较大,有效期大概2天,所以请及时下载。

好的,非常感谢!

我们并不格外在乎是不是有很多issue,我们关心的是每个issue都应该是准确、清晰的。之前可能关闭过一些您提交的issue,主要是因为它可能与已有的issue重复。这种情况下,通常我们为了简洁都会把新提交的issue标记为重复并且关闭掉

@bb33bb
Copy link
Author

bb33bb commented Oct 31, 2024

https://1drv.ms/u/c/01e018a652fc6a6e/EekHqe_uuPFHidQsR7GI9cUBWE5_W8SyLnU_2l_IkaTAqQ?e=9d7L7g

I am re-opening this issue because it is a valid issue. I have seen it before but I did not create an issue for it. Please take your time to find the file
We do not mind having more issues open, so please do not close them if they are not yet resolved

好的,确实之前怕这里添加太多麻烦给您。谢谢! 我把这个文件上传上来。稍等一下午。文件比较大,有效期大概2天,所以请及时下载。

好的,非常感谢!

我们并不格外在乎是不是有很多issue,我们关心的是每个issue都应该是准确、清晰的。之前可能关闭过一些您提交的issue,主要是因为它可能与已有的issue重复。这种情况下,通常我们为了简洁都会把新提交的issue标记为重复并且关闭掉

https://1drv.ms/u/c/01e018a652fc6a6e/EekHqe_uuPFHidQsR7GI9cUBWE5_W8SyLnU_2l_IkaTAqQ?e=9d7L7g
https://1drv.ms/u/c/01e018a652fc6a6e/EYSbOjzjvDRJkjzEkI7hwKABPBCsLGzhjphFpKQ6CSl_1w?e=DpZAjz

@xusheng6
Copy link
Member

xusheng6 commented Nov 1, 2024

v35 folks should search for "garden correct silver bubble star" to find the file

@plafosse plafosse added Type: Enhancement Issue is a small enhancement to existing functionality Effort: High Issue should take > 1 month Impact: Medium Issue is impactful with a bad, or no, workaround and removed State: Blocked (Customer) Issue is blocked on waiting for a response from a customer labels Nov 5, 2024
@plafosse
Copy link
Member

plafosse commented Nov 5, 2024

This is dependent on #1013 which we've scheduled for our Gallifrey release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: High Issue should take > 1 month Impact: Medium Issue is impactful with a bad, or no, workaround Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants