Skip to content

The default rendering of an integer data varible should consider its type information #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bb33bb opened this issue Oct 23, 2024 · 4 comments
Labels
Component: UI Issue needs changes to the user interface Effort: Low Issue should take < 1 week Impact: Low Issue is a papercut or has a good, supported workaround State: Duplicate Issue is a duplicate of another issue Type: Enhancement Issue is a small enhancement to existing functionality UI: Linear Issues with the Linear view

Comments

@bb33bb
Copy link

bb33bb commented Oct 23, 2024

Version and Platform (required):

  • Binary Ninja Version: 4.2.6262-dev Personal (5c271eff)
  • OS: manjaro Latest x64
  • OS Version: Linux version 6.10.13-3-MANJARO (builduser@fv-az1246-770) (gcc (GCC) 14.2.1 20240910, GNU ld (GNU Binutils) 2.43.0) use Caches folder on OS X for download cache to prevent backups #1 SMP PREEMPT_DYNAMIC Tue Oct 8 03:24:49 UTC 2024
  • CPU Architecture: x64

Bug Description:

simplescreenrecorder-2024-10-23_15.49.53.mp4

as u can see , we expect the number to be like 0xffffffffxxxxxxxx
but it is not go as we expected

@psifertex
Copy link
Member

Right now the display type of the variable is mostly separate from the type system type of the variable. You can fix this by right clicking the integer itself and changing the display type.

That said, I agree the experience would be better if the display type for signedness was influenced by the actual type. Leaving the issue open to track that.

@bb33bb
Copy link
Author

bb33bb commented Oct 28, 2024

Right now the display type of the variable is mostly separate from the type system type of the variable. You can fix this by right clicking the integer itself and changing the display type.

That said, I agree the experience would be better if the display type for signedness was influenced by the actual type. Leaving the issue open to track that.

we can only use interaction method maybe.
I tried the api, also not successed.

@xusheng6 xusheng6 changed the title short key not function The default rendering of an integer data varible should consider its type information Oct 29, 2024
@xusheng6 xusheng6 added Type: Enhancement Issue is a small enhancement to existing functionality Component: UI Issue needs changes to the user interface Impact: Low Issue is a papercut or has a good, supported workaround Effort: Low Issue should take < 1 week UI: Linear Issues with the Linear view labels Oct 29, 2024
@xusheng6
Copy link
Member

Thanks for the bug report! I have actually ran into this myself a few times, but I was busy working on other things and just let it slip. I should have noticed that we are ignoring the type information. Apparently we should consider the type info when the rendering type is set to default

@CouleeApps
Copy link
Member

This seems like a duplicate of #6044 which was fixed recently. Closing as fixed for now but can reopen if this is actually something else.

@psifertex psifertex added the State: Duplicate Issue is a duplicate of another issue label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Low Issue should take < 1 week Impact: Low Issue is a papercut or has a good, supported workaround State: Duplicate Issue is a duplicate of another issue Type: Enhancement Issue is a small enhancement to existing functionality UI: Linear Issues with the Linear view
Projects
None yet
Development

No branches or pull requests

4 participants