Skip to content

Comment width not properly calculated if it contains non-ASCII chars and clickable addresses #5972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bb33bb opened this issue Oct 4, 2024 · 4 comments
Assignees
Labels
Component: UI Issue needs changes to the user interface Effort: Low Issue should take < 1 week Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps
Milestone

Comments

@bb33bb
Copy link

bb33bb commented Oct 4, 2024

Version and Platform (required):

Bug Description:
image

Steps To Reproduce:

https://1drv.ms/u/s!Am5q_FKmGOABgUXzcnl8S8jWVL3t?e=xYeQvo

@xusheng6
Copy link
Member

xusheng6 commented Oct 4, 2024

This is a new form of #1234. I checked and it seems we only fixed the specific issue with the width of a tab, and the general issue remains unsolved.

@xusheng6 xusheng6 changed the title comment display not OK Comment width not properly calculated if it contains non-ASCII chars Oct 4, 2024
@xusheng6 xusheng6 added Type: Bug Issue is a non-crashing bug with repro steps Component: UI Issue needs changes to the user interface Impact: Low Issue is a papercut or has a good, supported workaround Effort: Low Issue should take < 1 week labels Oct 8, 2024
@BlasterXiao
Copy link

what time will this problem be resolved? @xusheng6 i need this function!

@xusheng6 xusheng6 changed the title Comment width not properly calculated if it contains non-ASCII chars Comment width not properly calculated if it contains non-ASCII chars and clickable addresses Apr 21, 2025
@xusheng6
Copy link
Member

I looked a bit further into this, so it seems the fix #1234 works in the general case, but this is only happening when a clickable address shows up in the comment. If it is just a number, like 100003ee4, it works fine. The bug only happens when the text is like 0x100003ee4, where we did some special processing to get the number displayed as a clickable token

I cannot guarantee a timeline for this issue, but I will try to have a look at it in the next milestone. For now maybe consider a workaround like avoiding the "0x" prefix or use English in the comment

@xusheng6 xusheng6 self-assigned this Apr 21, 2025
@xusheng6 xusheng6 added this to the H milestone Apr 21, 2025
@BlasterXiao
Copy link

Another point affected by this issue is English and Chinese comments. For example, English comments don't have any problems, but switching to Chinese comments will cause overflow and related issues. @xusheng6
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Low Issue should take < 1 week Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps
Projects
None yet
Development

No branches or pull requests

3 participants